Release v6.5.2 #732
Merged
Release v6.5.2 #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
throw { ... } or reject({ ... }) is bad practice, but sometimes it happens. Previously (as
highlighted in #597), Bugsnag would just print [object Object], which is unhelpful. This
uses util.inspect() to get a better textual representation of anything that doesn't have
a .stack property, before logging it to the console.
Parially fixes #597
feat(node): Use util.inspect() before printing non-errors
Update to docker-compose-buildkite-plugin v.3.1.0 in preparation for Buildkite agent v4.3.5
…ugin chore (build): bump to docker-compose-buildkite-plugin v.3.1.0
Maintenance performed: - update to latest version of Node - remove manual breadcrumbs as not currently supported by Node - resolve issue in typescript example where .ts was not automatically transpiled
fix(delivery-x-domain-request): Fix incorrect "this" reference
Chore (Node example app maintenance)
bengourley
approved these changes
Feb 5, 2020
There was a problem hiding this comment.
Looks good.
This should go in the PR description too, for completeness' sake:
- (delivery-x-domain-request): Correct
this->clientreference when attempting to log an error #722
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
util.inspect()on plain object errors when logging their value #696Fixed
this->clientreference when attempting to log an error #722