plugin-express: fetch request body in onError #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the body may not exist when the request handler runs and so the body will be missing from the error report in the dashboard This can happen because the body may be parsed by middleware that runs after the requestHandler
|
I tested this manually and it worked as desired. I also figured a way to get the maze runner tests to verify this behaviour, so have pushed a test up for that. Tagging @twometresteve for a review from a testing POV. |
bengourley
approved these changes
Jun 2, 2020
twometresteve
approved these changes
Jun 2, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the body may not exist when the request handler runs and so the body will be missing from the error report in the dashboard
This can happen because the body may be parsed by middleware that runs after the
requestHandler, which is fairly likely because Bugsnag should be installed as early as possibleSee #620 for more details
I tried to write some tests for this but struggled to get anything working. I may be missing something but it seems like it's hard/impossible to test due to how the
requestHandlerworks (happy to be corrected though!)