Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin-express: fetch request body in onError #872

Merged
merged 5 commits into from
Jun 15, 2020
Merged

plugin-express: fetch request body in onError #872

merged 5 commits into from
Jun 15, 2020

Commits on Jun 1, 2020

  1. fix(plugin-express): fetch request body in onError 

    This fixes an issue where the body may not exist when the request
handler runs and so the body will be missing from the error report
in the dashboard

This can happen because the body may be parsed by middleware that
runs after the requestHandler
    @imjoehaines
    imjoehaines committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    6cb9a3b View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2020

  1. test(plugin-express): Add assertions for req.body in request metadata

    @bengourley
    bengourley committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    9540145 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2020

  1. chore: Update changelog

    @bengourley
    bengourley committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    988c9f3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'next' into fix-express-request-body

    @bengourley
    bengourley authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    e566faf View commit details
    Browse the repository at this point in the history

  3. Merge branch 'next' into fix-express-request-body

    @bengourley
    bengourley authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    4811928 View commit details
    Browse the repository at this point in the history