This change will ensure a single HTTP client is created #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure we get consistent connection reuse, pooling I have extracted the HTTP Client used by all collections. This client has been configured with a set of timeouts at both the client and transport level. I have used the following post as a reference https://blog.cloudflare.com/the-complete-guide-to-golang-net-http-timeouts
wolfeidau
added a commit
that referenced
this pull request
Jun 6, 2024
[Full Changelog](v5.9.5...v5.9.6) - This change enables configuration of http connection pooling [#286](#286) (@wolfeidau) - This change will ensure a single HTTP client is created [#285](#285) (@wolfeidau)
wolfeidau
added a commit
that referenced
this pull request
Jun 6, 2024
[Full Changelog](v5.9.5...v5.9.6) - This change enables configuration of http connection pooling [#286](#286) (@wolfeidau) - This change will ensure a single HTTP client is created [#285](#285) (@wolfeidau)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure we get consistent connection reuse, pooling I have extracted the HTTP Client used by all collections. This client has been configured with a set of timeouts at both the client and transport level.
I have used the following post as a reference https://blog.cloudflare.com/the-complete-guide-to-golang-net-http-timeouts