This change enables configuration of http connection pooling #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To provide customers with more options to tune for their situation this introduces a new option to reduce or disable connection reuse. In some cases disabling connection reuse may avoid read timeouts or pausing for connections a server, or CDN may deprioritize. I have also updated the documentation for the expanded timeout option to highlight it is used for more than just request timeout.
wolfeidau
force-pushed
the
feat_add_max_idle_connections
branch
from
b15f7a2
to
5e1c6df
Compare
DrJosh9000
approved these changes
Jun 5, 2024
Co-authored-by: Josh Deprez <[email protected]>
wolfeidau
added a commit
that referenced
this pull request
Jun 6, 2024
[Full Changelog](v5.9.5...v5.9.6) - This change enables configuration of http connection pooling [#286](#286) (@wolfeidau) - This change will ensure a single HTTP client is created [#285](#285) (@wolfeidau)
wolfeidau
added a commit
that referenced
this pull request
Jun 6, 2024
[Full Changelog](v5.9.5...v5.9.6) - This change enables configuration of http connection pooling [#286](#286) (@wolfeidau) - This change will ensure a single HTTP client is created [#285](#285) (@wolfeidau)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To provide customers with more options to tune for their situation this introduces a new option to reduce or disable connection reuse. In some cases disabling connection reuse may avoid read timeouts or pausing for connections a server, or CDN may deprioritize.
I have also updated the documentation for the expanded timeout option to highlight it is used for more than just request timeout.
Also disabled redirects, again to ensure the client completes the operation quickly.
See https://github.com/golang/go/blob/master/src/net/http/transport.go#L44-L55 for more context on the defaults.