Change EventScheduleRate parameter to EventSchedulePeriod and require units
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… require units The rate expression must pluralise the unit, so `1 minute` and `0 minutes` are valid, but `0 minute` is not. Rather than condition on the value of the parameter, we leave this to the user to specify whether they should use "minute" or "minutes". This also allows them to use other units like 1 hour, 1 day, etc. Though units that are longer or shorter than a minute are not recommended.
triarius
force-pushed
the
pdp-1417-buildkite-agent-scaler-event-schedule-rate-parameter-should
branch
from
bcb432f
to
e8d2d80
Compare
triarius
changed the title
EventScheduleRate parameter to EventSchedulePeriod and make require units
triarius
changed the title
EventScheduleRate parameter to EventSchedulePeriod and make require unitsEventScheduleRate parameter to EventSchedulePeriod and require units
triarius
deleted the
pdp-1417-buildkite-agent-scaler-event-schedule-rate-parameter-should
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rate expression must pluralise the unit, so
1 minuteand0 minutesare valid, but0 minuteis not.Rather than condition on the value of the parameter, we leave this to
the user to specify whether they should use "minute" or "minutes". This
also allows them to use other units like 1 hour, 1 day, etc. Though
units that are longer or shorter than a minute are not recommended.
Since the old parameter was essentially broken (it would not succeed with any value other than the default,
1), we've decided to rename the parameter toEventSchedulePeriod. This name is more accurate - a length of time like 1 minute is not a rate.