Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change EventScheduleRate parameter to EventSchedulePeriod and require units #102

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ Parameters:
Type: String
Default: ''

EventScheduleRate:
Description: How often the Event Schedule is triggered (in minutes)
EventSchedulePeriod:
Description: How often the Event Schedule is triggered. Should be an expression with units, e.g. "30 seconds", "1 minute", "5 minutes".
Type: String
Default: "1"
Default: "1 minute"

AgentsPerInstance:
Description: ""
Expand Down Expand Up @@ -89,7 +89,7 @@ Parameters:
Type: Number
Description: The number of pages to retrive for DescribeScalingActivity. Negative numbers mean unlimited.
Default: "-1"

MinPollInterval:
Type: String
Description: Minimum time interval between polls. If a larger interval is provided by Buildkite, that is used instead.
Expand Down Expand Up @@ -213,7 +213,7 @@ Resources:
Timer:
Type: Schedule
Properties:
Schedule: !Sub "rate(${EventScheduleRate} minute)"
Schedule: !Sub "rate(${EventSchedulePeriod})"

# This mirrors the group that would be created by the lambda, but enforces
# a retention period and also ensures it's removed when the stack is removed
Expand Down