Move vertical box plot legends to the top #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamabeshouse
force-pushed
the
legend-top-plots
branch
from
a94ec6e
to
043fcf4
Compare
adamabeshouse
force-pushed
the
legend-top-plots
branch
5 times, most recently
from
ff0403e
to
4f441d1
Compare
|
@adam does this take legend width into account? or does the wrapping somehow prevent legend from ever overflowing? |
alisman
reviewed
Aug 10, 2018
| return ( | ||
| <VictoryLegend | ||
| orientation="vertical" | ||
| orientation={this.props.horizontal ? "vertical" : "horizontal"} |
There was a problem hiding this comment.
so there is still a case where legend will be vertical?
There was a problem hiding this comment.
yes, if the box plot is oriented so that more boxes go down instead of to the right. what do you think?
|
@alisman heuristically the |
…r to the right Signed-off-by: Abeshouse, Adam A./Sloan Kettering Institute <[email protected]>
adamabeshouse
force-pushed
the
legend-top-plots
branch
from
4f441d1
to
5c2ae38
Compare
alisman
approved these changes
Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.