Give option to list unselected cases in the Custom Selection component #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhx828
commented
Aug 7, 2019
| onClick(event: any) { | ||
| let cases; | ||
| let caseInverted; | ||
| if(event.target.id == "selected") { |
There was a problem hiding this comment.
I would rather you pass the status as parameter into onClick function
| this.content = cases.join("\n") | ||
| } | ||
| if(event.target.id == "unselected") { | ||
| caseInverted = this.props.allSamples.map(sample => { |
There was a problem hiding this comment.
When you choose unselected, it's the complement set of this.props.selectedSamples in this.props.allSamples
| onClick={this.onClick}> | ||
| currently selected | ||
| </span> | ||
| <span id={"unselected"} |
There was a problem hiding this comment.
This option should be disabled when no case has been selected.
Signed-off-by: Hongxin Zhang <[email protected]>
update logic
kalletlak
reviewed
Aug 12, 2019
| if (selectMode === "selected") { | ||
| selectedCases = this.props.selectedSamples; | ||
| } else { | ||
| const _selectedCaseIds = this.props.selectedSamples.map(sample => sample.sampleId); |
There was a problem hiding this comment.
Why not create a Map instead of List for looking if its present or not
|
This pr is closed due to long term our of sync. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves cBioPortal/cbioportal#6361