Give option to list unselected cases in the Custom Selection component #2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalletlak
reviewed
Dec 17, 2019
| if (selectMode === SelectMode.SELECTED) { | ||
| selectedCases = this.props.selectedSamples; | ||
| } else { | ||
| const _selectedCaseIds = _.reduce(this.props.selectedSamples, (acc, next) => { |
There was a problem hiding this comment.
may be _.keyBy(this.props.selectedSamples,sample=>sample.uniqueSampleKey)
There was a problem hiding this comment.
@kalletlak I can update. But do they have same performance? Or just for convenience?
kalletlak
approved these changes
Dec 18, 2019
|
I think the UI is a tiny bit confusing now. I would suggest something like this it's more clear they are opposites of each other.
|
alisman
requested changes
Dec 19, 2019
|
@alisman very similar. fontawesome does not have the exact icon in your screenshot |
zhx828
force-pushed
the
dup-2589
branch
2 times, most recently
from
85e8cce
to
c466c79
Compare
Signed-off-by: Hongxin Zhang <[email protected]>
|
@zhx828 @alisman @kalletlak it seems like this PR didn't go through product review? Let's discuss on engineering meeting how we can avoid accidentally merging things that still need review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves cBioPortal/cbioportal#6361
This is an improvement pr of #2589