Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added an option to change the behavior of selection when all values selected #2913

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

onursumer
Copy link
Member

Related to cBioPortal/cbioportal/issues/6883.

This does NOT fix the issue. This is only to release the next version of cbioportal-frontend-commons. I will have a separate PR to fix the issue once react-mutation-mapper is updated with this version of cbioportal-frontend-commons.

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

@onursumer onursumer requested a review from inodb December 5, 2019 19:21
@onursumer onursumer merged commit 31a57ae into cBioPortal:master Dec 5, 2019
@onursumer onursumer deleted the checklist-special-select branch December 5, 2019 23:02
@inodb inodb added the style tweak To indicate the PR does a minor style tweak label Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style tweak To indicate the PR does a minor style tweak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants