Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutation mapper selection button behavior on first click #6883

Closed
inodb opened this issue Dec 3, 2019 · 2 comments
Closed

mutation mapper selection button behavior on first click #6883

inodb opened this issue Dec 3, 2019 · 2 comments

Comments

@inodb
Copy link
Member

inodb commented Dec 3, 2019

Would it be possible to have the first click select the mutation type you are clicking on and deselect everything else? Currently the mutation type you click on becomes unselected with everything else selected, which is the opposite of what the behavior was before

@inodb inodb changed the title minor change mutation mapper selection buttons mutation mapper selection button behavior on first click Dec 3, 2019
@onursumer
Copy link
Member

Yes, we can do something like this:

if (all selected)
    deselect all except the clicked one
else
    toggle the clicked one

onursumer added a commit to onursumer/cbioportal-frontend that referenced this issue Dec 5, 2019
onursumer added a commit to onursumer/react-mutation-mapper that referenced this issue Dec 5, 2019
onursumer added a commit to onursumer/cbioportal-frontend that referenced this issue Dec 5, 2019
onursumer added a commit to onursumer/cbioportal-frontend that referenced this issue Dec 5, 2019
onursumer added a commit to onursumer/react-mutation-mapper that referenced this issue Dec 5, 2019
onursumer added a commit to onursumer/cbioportal-frontend that referenced this issue Dec 6, 2019
onursumer added a commit to onursumer/cbioportal-frontend that referenced this issue Dec 6, 2019
onursumer added a commit to onursumer/cbioportal-frontend that referenced this issue Dec 6, 2019
onursumer added a commit to onursumer/cbioportal-frontend that referenced this issue Dec 9, 2019
ChrisWakefield pushed a commit to ChrisWakefield/cbioportal-frontend that referenced this issue Dec 9, 2019
@onursumer
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants