Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded react-mutation-mapper version to 0.3.3 #2919

Closed

Conversation

onursumer
Copy link
Member

Fix cBioPortal/cbioportal/issues/6883

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

@onursumer onursumer requested a review from inodb December 6, 2019 03:06
@jjgao jjgao temporarily deployed to cbioportal-f-react-muta-ahrf41 December 6, 2019 03:06 Inactive
@inodb inodb added the style tweak To indicate the PR does a minor style tweak label Dec 6, 2019
@jjgao jjgao temporarily deployed to cbioportal-f-react-muta-ahrf41 December 6, 2019 16:50 Inactive
@jjgao jjgao temporarily deployed to cbioportal-f-react-muta-ahrf41 December 9, 2019 17:22 Inactive
@zhx828
Copy link
Member

zhx828 commented Dec 9, 2019

The component will be updated in #2923

@zhx828 zhx828 closed this Dec 9, 2019
@onursumer onursumer deleted the react-mutation-mapper-0.3.3 branch December 18, 2019 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style tweak To indicate the PR does a minor style tweak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mutation mapper selection button behavior on first click
4 participants