Gene query limit supports case sets #2924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Issue: - Case sets were ignored when determining if a gene query was over the limit - This caused case sets that are a proper subset of their studies to limit the number of genes too strictly - Solution: - Consider all the ways the user could be restricting their sample set when creating a query
Luke-Sikina
commented
Dec 10, 2019
| * 3. The number of samples in the selected sample list | ||
| * 4. The number of samples in the selected profiled samples result | ||
| */ | ||
| @computed get approxSampleCount(): number { |
There was a problem hiding this comment.
Even though this will be accurate the vast majority of the time, I felt it was important to label it as approximate given that it can be off if the user has a custom case list of patients that have more than one sample.
alisman
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal#6898
Describe changes proposed in this pull request:
was over the limit
studies to limit the number of genes too strictly
their sample set when creating a query