Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imported react-mutation-mapper repo #2957

Merged
merged 54 commits into from
Jan 3, 2020

Conversation

onursumer
Copy link
Member

@onursumer onursumer commented Dec 27, 2019

  • Imported react-mutation-mapper repo with commit history using lerna import (number of commits is intentional)
  • Updated dependencies and scripts to integrate react-mutation-mapper
  • Cleaned up readme and docs

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

@onursumer onursumer force-pushed the react-mutation-mapper-import branch 4 times, most recently from 9eea1cb to b78476c Compare December 31, 2019 18:12
@onursumer onursumer marked this pull request as ready for review December 31, 2019 18:58
@onursumer
Copy link
Member Author

The only commit that needs to be reviewed is 41e7450. The rest was imported from react-mutation-mapper repo.

@zhx828 zhx828 added the feature label Jan 3, 2020
@zhx828 zhx828 merged commit 2066840 into cBioPortal:master Jan 3, 2020
@onursumer onursumer deleted the react-mutation-mapper-import branch January 3, 2020 19:10
@inodb inodb added refactoring and removed feature labels Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants