Show gnomad in number #2987
Show gnomad in number #2987
Conversation
| @@ -145,7 +145,8 @@ export default class GnomadFrequency extends React.Component<GnomadFrequencyProp | |||
| if (result["Total"].alleleFrequency === 0) { | |||
| display = <span>0</span>; | |||
| } else { | |||
| display = <span>{parseFloat(result["Total"].alleleFrequency.toString()).toExponential(1)}</span>; | |||
| // show frequency as number with 4 significant digits | |||
| display = <span>{significantDigits(result['Total'].alleleFrequency, 4)}</span>; | |||
There was a problem hiding this comment.
we have a library called Numeral.js (google it for docs) which should do this. lets use it instead.
There was a problem hiding this comment.
@alisman thanks! Basically what I'm looking for is to "round" number to 4 significant digits. I take a look at the Numeral.js doc but I'm not sure if it has the function I need, but I found another way to do it:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/NumberFormat
do you think it's ok to use?
There was a problem hiding this comment.
Ok, i see you are right numeral.js doesn't seem to have min/max significant digits. I put another comment in. As a general rule, try to avoid writing library code unless necessary and discuss with team if you think you do need to do so.
| @@ -146,7 +145,11 @@ export default class GnomadFrequency extends React.Component<GnomadFrequencyProp | |||
| display = <span>0</span>; | |||
| } else { | |||
| // show frequency as number with 4 significant digits | |||
| display = <span>{significantDigits(result['Total'].alleleFrequency, 4)}</span>; | |||
| var significantDigitsFormatter = new Intl.NumberFormat("en", { | |||
There was a problem hiding this comment.
Yes, I think this is fine. Support looks good. However, I would subsistute the following https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toLocaleString
It has the same options and doesn't confuse so much with "Intl"
Also, it seems that passing the locale ("en") is optional. If so, we should just not pass anything as we are not localized and we intend to use same formatting for any locale.
There was a problem hiding this comment.
@alisman thanks, one minor thing is that it looks like I have to pass a locale anyway, so I pass undefined there.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "react-mutation-mapper", | |||
| "version": "0.4.2", | |||
| "version": "0.4.3", | |||
There was a problem hiding this comment.
we should also increment the version for cbioportal-frontend package.json
leexgh
force-pushed
the
show-gnomad-in-number
branch
from
28ea256
to
74f424c
Compare
|
awaiting @jjgao approval of the number column treatment |
|
per discuss on slack, we'll keep two significant digits, e.g. 0.000016. |
leexgh
force-pushed
the
show-gnomad-in-number
branch
from
d98a79d
to
e4cd114
Compare
|
@jjgao @alisman @onursumer updated to 2 significant digits, could you take a look again? thanks |
leexgh
force-pushed
the
show-gnomad-in-number
branch
from
e4cd114
to
766bd29
Compare
show gnomad in number with 2 non-zero digits after decimal point
left align with different length of number
