Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error while fetching referenceGenomeSize #2991

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Fix error while fetching referenceGenomeSize #2991

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/patientView/genomicOverview/tracksHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export function getChmInfo(genomeBuild:string) {
if (!referenceGenome || referenceGenome === "") {
referenceGenome = DEFAULT_GENOME_BUILD;
}
const genomeSize = referenceGenomeSizes[genomeBuild];
const genomeSize = referenceGenomeSizes[referenceGenome];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a sense why this working for other patients? seems like we were using the key instead of the value

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for other patients ncbiBuild of first mutation is in one of referenceGenomeSizes keys

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @alisman , @kalletlak , my mistake, should be referenceGenome. Thanks!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @khzhu !!!

if (genomeSize) {
sel.genomeRef = genomeSize;
sel.total = _.sum(genomeSize);
Expand Down