Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SemanticVersion missing equals/not equals operator, prerelease sorted wrong #3711

Closed
devlead opened this issue Nov 23, 2021 · 1 comment · Fixed by #3712
Closed

SemanticVersion missing equals/not equals operator, prerelease sorted wrong #3711

devlead opened this issue Nov 23, 2021 · 1 comment · Fixed by #3712
Assignees
@devlead
Labels
Bug
Milestone
v2.0.0

Comments

@devlead
Copy link
Member

devlead commented Nov 23, 2021

Current behaviour

new SemanticVersion(1,0,0) == new SemanticVersion(1,0,0) == false
new SemanticVersion(1,0,0) > new SemanticVersion(1,0,0, "rc0001") == false

Expected behaviour

new SemanticVersion(1,0,0) == new SemanticVersion(1,0,0) == true
new SemanticVersion(1,0,0) > new SemanticVersion(1,0,0, "rc0001") == true

I'll send a pr shortly to address this.
@devlead devlead added the Bug label Nov 23, 2021
@devlead devlead added this to the v2.0.0 milestone Nov 23, 2021
@devlead devlead self-assigned this Nov 23, 2021
devlead added a commit to devlead/cake that referenced this issue Nov 23, 2021
@devlead
(cake-buildGH-3711) Fix SemanticVersion operator & comparer
70ddedf 
* Adds SemanticVersion equals operator
* Adds SemanticVersion not equals operator
* Fixes PreRelease sorted as newer than non PreRelease
* Adds SemanticVersion tests
* Fixes cake-build#3711
@devlead devlead mentioned this issue Nov 23, 2021
Merged
@gep13 gep13 changed the title SemanticVersion missing equals/not equals operator, prerelease sortet wrong SemanticVersion missing equals/not equals operator, prerelease sorted wrong Nov 23, 2021
gep13 added a commit that referenced this issue Nov 23, 2021
@gep13
Merge pull request #3712 from devlead/feature/gh-3711
3d732f7 
GH3711: Fix SemanticVersion missing operators & comparer
@augustoproiete augustoproiete mentioned this issue Nov 23, 2021
Closed
@cake-build-bot
Copy link

🎉 This issue has been resolved in version v2.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devlead devlead

Labels
Bug
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

GH3711: Fix SemanticVersion missing operators & comparer devlead/cake
2 participants
@devlead @cake-build-bot