Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH3711: Fix SemanticVersion missing operators & comparer #3712

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

devlead
Copy link
Member

@devlead devlead commented Nov 23, 2021

* Adds SemanticVersion equals operator
* Adds SemanticVersion not equals operator
* Fixes PreRelease sorted as newer than non PreRelease
* Adds SemanticVersion tests
* Fixes cake-build#3711
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 3d732f7 into cake-build:develop Nov 23, 2021
@gep13
Copy link
Member

gep13 commented Nov 23, 2021

@devlead your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SemanticVersion missing equals/not equals operator, prerelease sorted wrong
2 participants