test: Add more orgs tests #12241

hariombalhara · 2023-11-06T10:04:03Z

What does this PR do?

Adds tests to verify

Org creation and onboarding
Org member invitation

Based on @leog's work in #11804 as I didn't have write access to the PR. I did some small fixes and code cleanup.

How should this be tested?

yarn e2e organization

Mandatory Tasks

Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

vercel · 2023-11-06T10:04:13Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 15, 2023 8:03am
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 15, 2023 8:03am
dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 15, 2023 8:03am

4 Ignored Deployments

Name	Status	Preview	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview	Nov 15, 2023 8:03am
cal-demo	⬜️ Ignored (Inspect)	Visit Preview	Nov 15, 2023 8:03am
qa	⬜️ Ignored (Inspect)	Visit Preview	Nov 15, 2023 8:03am
ui	⬜️ Ignored (Inspect)	Visit Preview	Nov 15, 2023 8:03am

github-actions · 2023-11-06T10:04:18Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

hariombalhara · 2023-11-06T10:04:39Z

apps/web/pages/signup.tsx

@@ -143,7 +143,7 @@ export default function Signup({ prepopulateFormValues, token, orgSlug, orgAutoA
                    methods.clearErrors("apiError");
                  }

-                  if (methods.getValues().username === undefined && isOrgInviteByLink && orgAutoAcceptEmail) {
+                  if (!methods.getValues().username && isOrgInviteByLink && orgAutoAcceptEmail) {


empty username isn't valid so, let's compute username from email in that case as well.

socket-security · 2023-11-06T10:12:43Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
@types/jsdom	21.1.5	None	`+1`	35.4 kB	types

hariombalhara · 2023-11-06T10:19:19Z

apps/web/pages/signup.tsx

@@ -37,7 +37,7 @@ type SignupProps = inferSSRProps<typeof getServerSideProps>;
 const checkValidEmail = (email: string) => z.string().email().safeParse(email).success;

 const getOrgUsernameFromEmail = (email: string, autoAcceptEmailDomain: string) => {
-  const [emailUser, emailDomain] = email.split("@");
+  const [emailUser, emailDomain = ""] = email.split("@");


The issue arises when form is submitted without entering the email or email doesn't have @ in it when it was submitted.

github-actions · 2023-11-06T11:00:10Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2023-11-06T11:01:15Z

Current Playwright Test Results Summary

✅ 318 Passing - ⚠️ 8 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/15/2023 08:07:03am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 7943f83

Started: 11/15/2023 07:59:06am UTC

⚠️ Flakes

📄 apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA Retry 1 • Initial Attempt	0.39% (1) 1 / 258 run failed over last 7 days	32.56% (84) 84 / 258 runs flaked over last 7 days

📄 apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and multiselect Question Phone required and multiselect text not required Retry 1 • Initial Attempt	1.21% (3) 3 / 248 runs failed over last 7 days	0.81% (2) 2 / 248 runs flaked over last 7 days

📄 apps/web/playwright/booking/addressQuestione2e/addressQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking With Address Question and Each Other Question Booking With Address Question and multiselect Question Address required and multiselect text required Retry 1 • Initial Attempt	0% (0) 0 / 259 runs failed over last 7 days	1.54% (4) 4 / 259 runs flaked over last 7 days

📄 apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests user Different Locations Tests Can add Link Meeting as location and book with it Retry 1 • Initial Attempt	0.75% (2) 2 / 266 runs failed over last 7 days	6.77% (18) 18 / 266 runs flaked over last 7 days

📄 apps/web/playwright/organization/organization-creation.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Organization should be able to create an organization and complete onboarding Retry 2 • Retry 1 • Initial Attempt	0% (0) 0 / 3 runs failed over last 7 days	100% (3) 3 / 3 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 2 • Retry 1 • Initial Attempt	16.97% (47) 47 / 277 runs failed over last 7 days	79.06% (219) 219 / 277 runs flaked over last 7 days
Popup Tests should open embed iframe on click - Configured with light theme Retry 1 • Initial Attempt	1.08% (3) 3 / 278 runs failed over last 7 days	55.76% (155) 155 / 278 runs flaked over last 7 days

📄 apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
FORM_SUBMITTED on submitting team form, triggers team webhook Retry 1 • Initial Attempt	1.12% (3) 3 / 269 runs failed over last 7 days	13.38% (36) 36 / 269 runs flaked over last 7 days

View Detailed Build Results

hariombalhara

Self reviewed

packages/trpc/server/routers/viewer/organizations/create.handler.ts

hariombalhara · 2023-11-07T08:45:07Z

packages/trpc/server/routers/viewer/organizations/create.handler.ts

@@ -175,7 +170,6 @@ export const createHandler = async ({ input, ctx }: CreateOptions) => {

    return { user: { ...createOwnerOrg, password } };
  } else {
-    if (!IS_PRODUCTION) return { checked: true };


I don't think it's needed. Code verification still accepts any code for dev mode, so there is no need to skip sending email

hariombalhara · 2023-11-15T07:33:20Z

Current dependencies on/for this PR:

main
- PR test: Add more orgs tests #12241 👈
  - PR fix: Across Org Scenarios - Wrong links for event and team #12358

This stack of pull requests is managed by Graphite.

keithwillcode

Amazing work on these tests, @hariombalhara

* feat: integrate formbricks in help feedback box * Update yarn.lock * Update yarn.lock * fix: use formbricks/[email protected] & set user with userId linked to feedback * fix: use separate env vars as suggested * test: Add more orgs tests (#12241) * feat: integrate formbricks in help feedback box * Update yarn.lock * fix: yarn lockfile * fix: yarn lockfile again * feat: link cal and formbricks user.id and add attributes of email and username to formbricks person object * Update yarn.lock * Update yarn.lock * fix: type safety in enums --------- Co-authored-by: Peer Richelsen <[email protected]> Co-authored-by: Hariom Balhara <[email protected]> Co-authored-by: Peer Richelsen <[email protected]>

zomars added the core area: core, team members only label Nov 6, 2023

hariombalhara commented Nov 6, 2023

View reviewed changes

hariombalhara force-pushed the chore/orgs-creation-invitation-e2e branch from 86f9500 to 0033b86 Compare November 6, 2023 10:12

hariombalhara changed the title ~~chore: add more orgs tests~~ test: Add more orgs tests Nov 6, 2023

vercel bot deployed to Preview – ai November 6, 2023 10:16 View deployment

vercel bot had a problem deploying to Preview – dev November 6, 2023 10:17 Failure

hariombalhara force-pushed the chore/orgs-creation-invitation-e2e branch from 0033b86 to dfdc257 Compare November 6, 2023 10:17

hariombalhara commented Nov 6, 2023

View reviewed changes

vercel bot deployed to Preview – ai November 6, 2023 10:21 View deployment

vercel bot had a problem deploying to Preview – dev November 6, 2023 10:21 Failure

vercel bot deployed to Preview – api November 6, 2023 10:24 View deployment

hariombalhara force-pushed the chore/orgs-creation-invitation-e2e branch from dfdc257 to c37d1cb Compare November 6, 2023 10:38

vercel bot deployed to Preview – ai November 6, 2023 10:42 View deployment

hariombalhara force-pushed the chore/orgs-creation-invitation-e2e branch from c37d1cb to e8f3da3 Compare November 6, 2023 10:42

vercel bot deployed to Preview – ai November 6, 2023 10:46 View deployment

vercel bot had a problem deploying to Preview – dev November 6, 2023 10:47 Failure

vercel bot deployed to Preview – api November 6, 2023 10:50 View deployment

hariombalhara force-pushed the chore/orgs-creation-invitation-e2e branch from e8f3da3 to 6842798 Compare November 6, 2023 10:53

hariombalhara marked this pull request as ready for review November 6, 2023 10:53

vercel bot deployed to Preview – ai November 6, 2023 10:57 View deployment

vercel bot deployed to Preview – api November 6, 2023 10:59 View deployment

vercel bot deployed to Preview – dev November 6, 2023 11:03 View deployment

hariombalhara force-pushed the chore/orgs-creation-invitation-e2e branch 2 times, most recently from 7c03444 to 5acbb58 Compare November 6, 2023 12:13

vercel bot deployed to Preview – ai November 6, 2023 12:18 View deployment

vercel bot deployed to Preview – dev November 7, 2023 05:05 View deployment

vercel bot deployed to Preview – api November 7, 2023 05:05 View deployment

hariombalhara requested a review from a team November 7, 2023 08:43

hariombalhara commented Nov 7, 2023

View reviewed changes

hariombalhara requested a review from a team November 13, 2023 13:21

vercel bot deployed to Preview – ai November 15, 2023 07:37 View deployment

vercel bot deployed to Preview – api November 15, 2023 07:39 View deployment

vercel bot deployed to Preview – dev November 15, 2023 07:41 View deployment

Add more org tests

7943f83

hariombalhara force-pushed the chore/orgs-creation-invitation-e2e branch from e74e60b to 7943f83 Compare November 15, 2023 07:54

vercel bot deployed to Preview – ai November 15, 2023 07:58 View deployment

hariombalhara mentioned this pull request Nov 15, 2023

fix: Across Org Scenarios - Wrong links for event and team #12358

Merged

11 tasks

vercel bot deployed to Preview – api November 15, 2023 07:59 View deployment

vercel bot deployed to Preview – dev November 15, 2023 08:03 View deployment

sean-brydon mentioned this pull request Nov 16, 2023

[CAL-2720] e2e tests for team invites #12386

Closed

PeerRich requested a review from zomars November 16, 2023 20:55

PeerRich added Medium priority Created by Linear-GitHub Sync automated-tests area: unit tests, e2e tests, playwright labels Nov 16, 2023

keithwillcode approved these changes Nov 21, 2023

View reviewed changes

keithwillcode merged commit 48dde24 into main Nov 21, 2023
37 checks passed

keithwillcode deleted the chore/orgs-creation-invitation-e2e branch November 21, 2023 17:03

ShubhamPalriwala pushed a commit to ShubhamPalriwala/cal.com that referenced this pull request Nov 22, 2023

test: Add more orgs tests (calcom#12241)

7e72672

ShubhamPalriwala pushed a commit to ShubhamPalriwala/cal.com that referenced this pull request Nov 22, 2023

test: Add more orgs tests (calcom#12241)

f0b6570

zomars pushed a commit that referenced this pull request Nov 22, 2023

test: Add more orgs tests (#12241)

c5c1a1f

zomars mentioned this pull request Nov 28, 2023

fix: team and org invite e2e tests #12566

Merged

3 tasks

hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Nov 28, 2023

test: Add more orgs tests (calcom#12241)

506b51f

jakazzy pushed a commit to jakazzy/cal.com that referenced this pull request Dec 5, 2023

test: Add more orgs tests (calcom#12241)

491913c

hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023

test: Add more orgs tests (calcom#12241)

fdf0410

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Add more orgs tests #12241

test: Add more orgs tests #12241

hariombalhara commented Nov 6, 2023 •

edited

Loading

vercel bot commented Nov 6, 2023 •

edited

Loading

github-actions bot commented Nov 6, 2023 •

edited

Loading

hariombalhara Nov 6, 2023 •

edited

Loading

socket-security bot commented Nov 6, 2023 •

edited

Loading

hariombalhara Nov 6, 2023

github-actions bot commented Nov 6, 2023 •

edited

Loading

deploysentinel bot commented Nov 6, 2023 •

edited

Loading

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

hariombalhara left a comment

hariombalhara Nov 7, 2023

hariombalhara commented Nov 15, 2023 •

edited

Loading

keithwillcode left a comment

test: Add more orgs tests #12241

test: Add more orgs tests #12241

Conversation

hariombalhara commented Nov 6, 2023 • edited Loading

What does this PR do?

How should this be tested?

Mandatory Tasks

vercel bot commented Nov 6, 2023 • edited Loading

github-actions bot commented Nov 6, 2023 • edited Loading

hariombalhara Nov 6, 2023 • edited Loading

Choose a reason for hiding this comment

socket-security bot commented Nov 6, 2023 • edited Loading

hariombalhara Nov 6, 2023

Choose a reason for hiding this comment

github-actions bot commented Nov 6, 2023 • edited Loading

📦 Next.js Bundle Analysis for @calcom/web

deploysentinel bot commented Nov 6, 2023 • edited Loading

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

hariombalhara left a comment

Choose a reason for hiding this comment

hariombalhara Nov 7, 2023

Choose a reason for hiding this comment

hariombalhara commented Nov 15, 2023 • edited Loading

keithwillcode left a comment

Choose a reason for hiding this comment

hariombalhara commented Nov 6, 2023 •

edited

Loading

vercel bot commented Nov 6, 2023 •

edited

Loading

github-actions bot commented Nov 6, 2023 •

edited

Loading

hariombalhara Nov 6, 2023 •

edited

Loading

socket-security bot commented Nov 6, 2023 •

edited

Loading

github-actions bot commented Nov 6, 2023 •

edited

Loading

deploysentinel bot commented Nov 6, 2023 •

edited

Loading

hariombalhara commented Nov 15, 2023 •

edited

Loading