fix: team and org invite e2e tests #12566

zomars · 2023-11-28T01:07:29Z

What does this PR do?

Fixes e2e tests for organizations and team invites
Removes the need for the clipboard fixture (introduced in test: Add more orgs tests #12241 ) as it resulted to be very flaky on CI
Removes clipboard fixture altogether to prevent future flaky tests due to it's usage

Type of change

Bug fix (non-breaking change which fixes an issue)
Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

Run tests for:

apps/web/playwright/team/team-invitation.e2e.ts
apps/web/playwright/organization/organization-invitation.e2e.ts

Mandatory Tasks

Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

vercel · 2023-11-28T01:07:31Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 28, 2023 6:22am
dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 28, 2023 6:22am

5 Ignored Deployments

Name	Status	Preview	Updated (UTC)
ai	⬜️ Ignored (Inspect)	Visit Preview	Nov 28, 2023 6:22am
cal	⬜️ Ignored (Inspect)	Visit Preview	Nov 28, 2023 6:22am
cal-demo	⬜️ Ignored (Inspect)	Visit Preview	Nov 28, 2023 6:22am
qa	⬜️ Ignored (Inspect)	Visit Preview	Nov 28, 2023 6:22am
ui	⬜️ Ignored (Inspect)	Visit Preview	Nov 28, 2023 6:22am

zomars · 2023-11-28T01:07:40Z

Current dependencies on/for this PR:

main
- PR fix: team and org invite e2e tests #12566 👈

This stack of pull requests is managed by Graphite.

github-actions · 2023-11-28T01:07:41Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

zomars

Self review done

zomars · 2023-11-28T01:11:55Z

apps/web/playwright/fixtures/clipboard.ts

Removed as it is very flaky by nature. Also relying in hacks like setTimeOut which makes it inconsistent across different machine speeds.

zomars · 2023-11-28T01:12:46Z

apps/web/playwright/lib/testUtils.ts

+export async function getInviteLink(page: Page) {
+  const response = await page.waitForResponse("**/api/trpc/teams/createInvite?batch=1");
+  const json = await response.json();
+  // @ts-expect-error trust me bro
+  const date = json[0].result.data.json.inviteLink as string;
+}


Instead of relying on the clipboard. I've refactored the endpoint so it returns the fully formed inviteLink from the server according to the team context.

zomars · 2023-11-28T01:13:38Z

packages/features/ee/teams/components/MemberInvitationModal.tsx

-
-    const inviteLink =
-      isOrgInvite || (props?.orgMembers && props.orgMembers?.length > 0) ? orgInviteLink : teamInviteLink;
+  const copyInviteLinkToClipboard = async (inviteLink: string) => {


We send the fully formed invite link from the server

zomars · 2023-11-28T01:14:00Z

packages/lib/server/queries/teams/index.ts

+      accepted: true,
+      OR: [{ role: "ADMIN" }, { role: "OWNER" }],
+    },
+    include: { team: true },


So we don't double query and can reuse the response

zomars · 2023-11-28T01:14:33Z

packages/trpc/server/routers/viewer/teams/createInvite.handler.ts

+  async function getInviteLink() {
+    const teamInviteLink = `${WEBAPP_URL}/teams?token=${token}`;
+    const orgInviteLink = `${WEBAPP_URL}/signup?token=${token}&callbackUrl=/getting-started`;
+    if (!isOrg) return teamInviteLink;
+    // Only fetch if is not an org
+    const orgMembers = await getMembersHandler({
+      ctx,
+      input: { teamIdToExclude: teamId, distinctUser: true },
+    });
+    if (!orgMembers) return teamInviteLink;
+    if (orgMembers.length < 1) return teamInviteLink;
+    return orgInviteLink;
+  }


In here we have all the context to form the invite link instead of relying on the client to do so.

github-actions · 2023-11-28T01:15:20Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2023-11-28T01:16:47Z

Current Playwright Test Results Summary

✅ 341 Passing - ⚠️ 8 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/28/2023 06:40:32am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: fd7caf6

Started: 11/28/2023 06:32:56am UTC

⚠️ Flakes

📄 apps/web/playwright/change-username.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Change username on settings User can change username to include periods(or dots) Retry 1 • Initial Attempt	0.80% (2) 2 / 251 runs failed over last 7 days	2.79% (7) 7 / 251 runs flaked over last 7 days

📄 apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
FORM_SUBMITTED on submitting team form, triggers team webhook Retry 2 • Retry 1 • Initial Attempt	3.41% (9) 9 / 264 runs failed over last 7 days	16.67% (44) 44 / 264 runs flaked over last 7 days

📄 apps/web/playwright/booking/phoneQuestion.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Booking With Phone Question and Each Other Question Booking With Phone Question and Address Question Booking With Phone Question and Multi email Question Phone required and Multi email not required Retry 1 • Initial Attempt	0.40% (1) 1 / 253 run failed over last 7 days	0.79% (2) 2 / 253 runs flaked over last 7 days

📄 apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests user -- future Different Locations Tests Can add Organzer Phone Number location and book with it Retry 1 • Initial Attempt	-0.61% (-1) -1 / 163 runs failed over last 7 days	6.75% (11) 11 / 163 runs flaked over last 7 days

📄 apps/web/playwright/organization/organization-creation.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Organization should be able to create an organization and complete onboarding Retry 1 • Initial Attempt	2.65% (6) 6 / 226 runs failed over last 7 days	94.69% (214) 214 / 226 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme Retry 1 • Initial Attempt	0.37% (1) 1 / 273 run failed over last 7 days	53.48% (146) 146 / 273 runs flaked over last 7 days
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	8.42% (23) 23 / 273 runs failed over last 7 days	88.28% (241) 241 / 273 runs flaked over last 7 days

📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link should validate fields Retry 1 • Initial Attempt	0.77% (2) 2 / 261 runs failed over last 7 days	8.43% (22) 22 / 261 runs flaked over last 7 days

View Detailed Build Results

zomars · 2023-11-28T06:42:58Z

As of now, all checks are passing

sean-brydon

LGTM - good fix. Clipboard was very flaky even in local so this is great

fix: team and org invite e2e tests

17ff619

zomars added core area: core, team members only devops labels Nov 28, 2023

zomars requested review from hariombalhara, sean-brydon and Udit-takkar November 28, 2023 01:09

vercel bot deployed to Preview – ai November 28, 2023 01:11 View deployment

vercel bot had a problem deploying to Preview – dev November 28, 2023 01:11 Failure

vercel bot deployed to Preview – api November 28, 2023 01:12 View deployment

zomars commented Nov 28, 2023

View reviewed changes

type fixes

7d3de25

vercel bot deployed to Preview – api November 28, 2023 01:25 View deployment

vercel bot deployed to Preview – dev November 28, 2023 01:33 View deployment

zomars marked this pull request as draft November 28, 2023 05:43

Test fixes

fd7caf6

vercel bot deployed to Preview – api November 28, 2023 06:17 View deployment

vercel bot deployed to Preview – dev November 28, 2023 06:22 View deployment

zomars marked this pull request as ready for review November 28, 2023 06:31

zomars enabled auto-merge (squash) November 28, 2023 06:43

sean-brydon approved these changes Nov 28, 2023

View reviewed changes

zomars merged commit c765ea9 into main Nov 28, 2023
44 checks passed

zomars deleted the fix_team_and_org_invite_e2e_tests branch November 28, 2023 10:49

sean-brydon mentioned this pull request Nov 28, 2023

feat: signup refactor #11421

Merged

jakazzy pushed a commit to jakazzy/cal.com that referenced this pull request Dec 5, 2023

fix: team and org invite e2e tests (calcom#12566)

a92d02c

hbjORbj pushed a commit to codemod-com/cal.com-demo that referenced this pull request Dec 21, 2023

fix: team and org invite e2e tests (calcom#12566)

83c6e4c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: team and org invite e2e tests #12566

fix: team and org invite e2e tests #12566

zomars commented Nov 28, 2023 •

edited

Loading

vercel bot commented Nov 28, 2023 •

edited

Loading

zomars commented Nov 28, 2023

github-actions bot commented Nov 28, 2023 •

edited

Loading

zomars left a comment

zomars Nov 28, 2023

zomars Nov 28, 2023

zomars Nov 28, 2023

zomars Nov 28, 2023

zomars Nov 28, 2023

github-actions bot commented Nov 28, 2023 •

edited

Loading

deploysentinel bot commented Nov 28, 2023 •

edited

Loading

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

zomars commented Nov 28, 2023

sean-brydon left a comment

fix: team and org invite e2e tests #12566

fix: team and org invite e2e tests #12566

Conversation

zomars commented Nov 28, 2023 • edited Loading

What does this PR do?

Type of change

How should this be tested?

Mandatory Tasks

vercel bot commented Nov 28, 2023 • edited Loading

zomars commented Nov 28, 2023

github-actions bot commented Nov 28, 2023 • edited Loading

zomars left a comment

Choose a reason for hiding this comment

zomars Nov 28, 2023

Choose a reason for hiding this comment

zomars Nov 28, 2023

Choose a reason for hiding this comment

zomars Nov 28, 2023

Choose a reason for hiding this comment

zomars Nov 28, 2023

Choose a reason for hiding this comment

zomars Nov 28, 2023

Choose a reason for hiding this comment

github-actions bot commented Nov 28, 2023 • edited Loading

📦 Next.js Bundle Analysis for @calcom/web

deploysentinel bot commented Nov 28, 2023 • edited Loading

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

zomars commented Nov 28, 2023

sean-brydon left a comment

Choose a reason for hiding this comment

zomars commented Nov 28, 2023 •

edited

Loading

vercel bot commented Nov 28, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023 •

edited

Loading

deploysentinel bot commented Nov 28, 2023 •

edited

Loading