Move some services to misc module (second pack) #3303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ger-benjamin
force-pushed
the
move_services_to_misc_module
branch
from
c2e99d7
to
41d9913
Compare
ger-benjamin
changed the title
ger-benjamin
force-pushed
the
move_services_to_misc_module
branch
from
41d9913
to
e8019c9
Compare
ger-benjamin
changed the title
ger-benjamin
force-pushed
the
move_services_to_misc_module
branch
from
e8019c9
to
b1b693e
Compare
fredj
reviewed
Dec 21, 2017
| @@ -1,7 +1,8 @@ | |||
| goog.provide('ngeo.DecorateInteraction'); | |||
| goog.provide('ngeo.misc.decorate'); | |||
There was a problem hiding this comment.
nice! we should move the layer decorator here (#3309)
There was a problem hiding this comment.
Yes !
I add a card about that: https://jira.camptocamp.com/browse/GSGMF-217
fredj
reviewed
Dec 21, 2017
| @@ -15,17 +16,9 @@ goog.require('ngeo'); | |||
| * | |||
| * See our live example: [../examples/interactiontoggle.html](../examples/interactiontoggle.html) | |||
There was a problem hiding this comment.
remove this line (the example is gone)
There was a problem hiding this comment.
I'll remove it in the third (and last) "misc" pack
fredj
approved these changes
Dec 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For GSGMF-214
Then, we still need to move that in the extra "misc" module (in another PR):