Move directives to misc module (third and last pack) #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ger-benjamin
commented
Dec 21, 2017
| @@ -14,8 +14,6 @@ goog.require('ol.interaction.Interaction'); | |||
| * | |||
| * <input type="checkbox" ngModel="interaction.active" /> | |||
| * | |||
| * See our live example: [../examples/interactiontoggle.html](../examples/interactiontoggle.html) | |||
There was a problem hiding this comment.
Address comment from PR: #3303 (comment)
ger-benjamin
changed the title
gberaudo
reviewed
Dec 21, 2017
| // … | ||
| }; | ||
| ngeo.module.directive('ngeoControl', ngeo.controlDirective); | ||
| ngeo.misc.controlComponent.directive('ngeoMiscControl', ngeo.misc.controlComponent.component_); |
There was a problem hiding this comment.
I think you should keep 'ngeoControl'.
There was a problem hiding this comment.
Yes, thanks, I don't know why I've done that
There was a problem hiding this comment.
Ahhh... but it's the guidlines. Does it matter ?
Perhaps it's even better to remove them...
There was a problem hiding this comment.
The guideline describes how to deal with the Closure compiler symbols but says nothing about renaming the names used in Angular.
There was a problem hiding this comment.
Ah, I understand what you mean now! ^^
OK, we can merge as it is.
gberaudo
approved these changes
Dec 21, 2017
|
@pfirpfel, if you have some time can you merge this PR tomorrow? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For and close GSGMF-214