Improve getting started experience for Camunda Cloud SaaS #132

ikheraj17 · 2021-11-04T16:00:08Z

Added 'dmn-repo' folder to repository with a sample dmn file inside; also modified yaml file to clarify where cloud credentials should be inputted

src/main/resources/application.yaml

lzgabel · 2021-11-04T21:01:54Z

src/main/resources/application.yaml

@@ -20,3 +25,5 @@ logging:
 management:
  server:
    port: 8081
+
+server.port: 8082


Maybe we can remove this config and use the default port.

src/main/java/io/zeebe/dmn/DmnJobHandler.java

saig0 · 2021-11-05T06:22:44Z

@ikheraj17 thank you for your contribution. Please give some context why do you make these changes.

falko · 2021-11-05T10:46:10Z

I changed the title of this PR to reflect that these changes are removing roadblocks that have cost @ikheraj17 and me a lot of unnecessary time to figure out how to get this worker running with Camunda Cloud SaaS.

falko · 2021-11-05T10:47:14Z

We are aware that the DMN implementation inside Zeebe is on its way but for the time being, the dmn-worker is the only option

saig0 · 2021-11-08T04:38:59Z

@falko the worker is built based on the Zeebe Spring starter. So, the configuration should be the same 😅

saig0 · 2021-11-08T04:41:46Z

dmn-repo/risk_check_en.dmn

+        <inputEntry id="UnaryTests_0c3lrnz">
+          <text></text>
+        </inputEntry>
+        <inputEntry id="UnaryTests_1l0btob">
+          <text>&lt;=85</text>
+        </inputEntry>
+        <outputEntry id="LiteralExpression_1f3y5xd">
+          <text>"Won't Pay In Time"</text>
+        </outputEntry>
+        <outputEntry id="LiteralExpression_1w57ha5">
+          <text>"red"</text>
+        </outputEntry>
+      </rule>
+      <rule id="DecisionRule_0s72fjf">
+        <description></description>
+        <inputEntry id="UnaryTests_1dkokb9">
+          <text></text>
+        </inputEntry>
+        <inputEntry id="UnaryTests_0d5r6v3">
+          <text>"Unemployed"</text>
+        </inputEntry>
+        <inputEntry id="UnaryTests_1v6fey5">
+          <text>not("Basic Package")</text>
+        </inputEntry>
+        <inputEntry id="UnaryTests_1rw2hjn">
+          <text>&lt;=95</text>
+        </inputEntry>
+        <outputEntry id="LiteralExpression_18kpqx8">
+          <text>"Lack Of Income"</text>
+        </outputEntry>
+        <outputEntry id="LiteralExpression_0mrbkzr">
+          <text>"red"</text>
+        </outputEntry>
+      </rule>
+      <rule id="DecisionRule_0c99hq3">
+        <description></description>
+        <inputEntry id="UnaryTests_16q1ghi">
+          <text>&lt;= 30</text>
+        </inputEntry>
+        <inputEntry id="UnaryTests_0c86j25">
+          <text>"Self-employed"</text>
+        </inputEntry>
+        <inputEntry id="UnaryTests_0l8wmca">
+          <text>"Premium Package"</text>
+        </inputEntry>
+        <inputEntry id="UnaryTests_1qkgqif">
+          <text></text>
+        </inputEntry>
+        <outputEntry id="LiteralExpression_0jlpe55">
+          <text>"Irregular And Possibly Lack Of Income"</text>
+        </outputEntry>
+        <outputEntry id="LiteralExpression_05qilq2">
+          <text>"yellow"</text>
+        </outputEntry>
+      </rule>
+      <rule id="DecisionRule_1euaw2y">
+        <description></description>
+        <inputEntry id="UnaryTests_0bctfm4">
+          <text></text>
+        </inputEntry>
+        <inputEntry id="UnaryTests_12o8otd">
+          <text>"Freelancer", "Self-employed"</text>
+        </inputEntry>
+        <inputEntry id="UnaryTests_0o842fe">
+          <text>-</text>
+        </inputEntry>
+        <inputEntry id="UnaryTests_1h8e7id">
+          <text>&lt;=95</text>
+        </inputEntry>
+        <outputEntry id="LiteralExpression_1pwrw8z">
+          <text>"Not Trustworthy"</text>
+        </outputEntry>
+        <outputEntry id="LiteralExpression_0zcjpew">
+          <text>"yellow"</text>
+        </outputEntry>
+      </rule>
+      <rule id="DecisionRule_08nz8pq">
+        <description></description>
+        <inputEntry id="UnaryTests_0adgp9c">
+          <text></text>
+        </inputEntry>
+        <inputEntry id="UnaryTests_1jzpweh">
+          <text>"Salaried"</text>
+        </inputEntry>
+        <inputEntry id="UnaryTests_17itih0">
+          <text>"Premium Package"</text>
+        </inputEntry>
+        <inputEntry id="UnaryTests_0dgmj4d">
+          <text>&lt;90</text>
+        </inputEntry>
+        <outputEntry id="LiteralExpression_1xwbye7">
+          <text>"Too Low Income"</text>
+        </outputEntry>
+        <outputEntry id="LiteralExpression_1s5g29d">
+          <text>"yellow"</text>
+        </outputEntry>
+      </rule>
+    </decisionTable>
+  </decision>
+</definitions>


@ikheraj17 why do you want to add an example DMN to the repository?

So that users immediately see the folder in which files have to go and also have a working example in case they are new to DMN.

@saig0 Are there any other outstanding issues regarding my pull request? If not, would you or the appropriate person please merge the changes that Falko and I have made? I'm in the process of creating documentation for the Camunda Cloud showcase, and the showcase's DMN functionality depends on this plugin. Please let me know if there are any other changes that you have questions about. Thank you!

@ikheraj17 I'm sorry for the delay. I was distracted by other duties 🙈

Currently, the build of this PR is failing. Something went wrong in the test case: WorkflowTest.shouldCompleteWorkflowInstance().

Error: Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 34.072 s <<< FAILURE! - in io.zeebe.dmn.WorkflowTest Error: shouldCompleteWorkflowInstance Time elapsed: 10.407 s <<< ERROR!

Are you able to build the PR locally?
I'll look into it today or tomorrow.

I can reproduce the test error locally. Looking into it...

falko · 2021-11-08T08:25:17Z

@falko the worker is built based on the Zeebe Spring starter. So, the configuration should be the same sweat_smile

Not everyone knows Spring Boot or our starter or all its configuration options by hard.

falko · 2021-11-08T08:33:37Z

Also, with the changes Imran suggested, the DMN worker works out of the box with our official Customer Onboarding Showcase that we use in all demos to Camunda Cloud prospects: https://github.com/camunda-consulting/showroom-customer-onboarding/tree/camunda-cloud

We frequently share that code with prospects for them to try it out themselves. We thought about copying the DMN worker code directly into the showcase repo but that would cut us off from updates and could lead customers to follow our example instead of using the official DMN worker. It also wouldn't give the due credit to you.

Co-authored-by: li zhi <[email protected]>

falko

BUILD SUCCESS

falko · 2021-11-18T17:41:22Z

@saig0 I'd suggest squashing all this mess together into one commit when merging ;-)

saig0

@ikheraj17 / @falko looks good 👍 Thanks you 🍰

ikheraj17 and others added 3 commits November 4, 2021 10:32

first push

b9ad2d0

update pom.xml dependency versions

a203d00

Reintroduce local config and improve documentation

03ba287

falko changed the title ~~Pull request to add dmn-repo folder, sample dmn file, and yaml file modification~~ Add dmn-repo folder, sample dmn file, and yaml sample for Camunda Cloud SaaS Nov 4, 2021

falko approved these changes Nov 4, 2021

View reviewed changes

lzgabel reviewed Nov 4, 2021

View reviewed changes

src/main/java/io/zeebe/dmn/DmnJobHandler.java Outdated Show resolved Hide resolved

falko changed the title ~~Add dmn-repo folder, sample dmn file, and yaml sample for Camunda Cloud SaaS~~ Improve getting started experience for Camunda Cloud SaaS Nov 5, 2021

saig0 reviewed Nov 8, 2021

View reviewed changes

falko and others added 7 commits November 8, 2021 09:35

Update application.yaml

80d720f

Switch to gateway address

2084e85

Co-authored-by: li zhi <[email protected]>

remove sysout logging

566f169

Merge branch 'master' of https://github.com/ikheraj17/zeebe-dmn-worker

29c9586

comment out cloud SaaS parameters

eb26a61

Merge branch 'master' of https://github.com/ikheraj17/zeebe-dmn-worker

43b0ec2

Merge branch 'camunda-community-hub:master' into master

e04e91b

saig0 self-requested a review November 18, 2021 05:17

falko added 2 commits November 18, 2021 18:32

Fix tests

332fdea

Remove clutter

f126433

falko reviewed Nov 18, 2021

View reviewed changes

saig0 approved these changes Nov 19, 2021

View reviewed changes

saig0 merged commit 5775d8d into camunda-community-hub:master Nov 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve getting started experience for Camunda Cloud SaaS #132

Improve getting started experience for Camunda Cloud SaaS #132

ikheraj17 commented Nov 4, 2021

lzgabel Nov 4, 2021

falko Nov 8, 2021

saig0 commented Nov 5, 2021

falko commented Nov 5, 2021

falko commented Nov 5, 2021 •

edited

Loading

saig0 commented Nov 8, 2021

saig0 Nov 8, 2021

falko Nov 8, 2021

ikheraj17 Nov 17, 2021

saig0 Nov 18, 2021

falko Nov 18, 2021

falko commented Nov 8, 2021

falko commented Nov 8, 2021

falko left a comment

falko commented Nov 18, 2021

saig0 left a comment

Improve getting started experience for Camunda Cloud SaaS #132

Improve getting started experience for Camunda Cloud SaaS #132

Conversation

ikheraj17 commented Nov 4, 2021

lzgabel Nov 4, 2021

Choose a reason for hiding this comment

falko Nov 8, 2021

Choose a reason for hiding this comment

saig0 commented Nov 5, 2021

falko commented Nov 5, 2021

falko commented Nov 5, 2021 • edited Loading

saig0 commented Nov 8, 2021

saig0 Nov 8, 2021

Choose a reason for hiding this comment

falko Nov 8, 2021

Choose a reason for hiding this comment

ikheraj17 Nov 17, 2021

Choose a reason for hiding this comment

saig0 Nov 18, 2021

Choose a reason for hiding this comment

falko Nov 18, 2021

Choose a reason for hiding this comment

falko commented Nov 8, 2021

falko commented Nov 8, 2021

falko left a comment

Choose a reason for hiding this comment

falko commented Nov 18, 2021

saig0 left a comment

Choose a reason for hiding this comment

falko commented Nov 5, 2021 •

edited

Loading