-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve getting started experience for Camunda Cloud SaaS #132
Merged
Merged
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b9ad2d0
first push
ikheraj17 a203d00
update pom.xml dependency versions
ikheraj17 03ba287
Reintroduce local config and improve documentation
falko 80d720f
Update application.yaml
falko 2084e85
Switch to gateway address
falko 566f169
remove sysout logging
ikheraj17 29c9586
Merge branch 'master' of https://github.com/ikheraj17/zeebe-dmn-worker
ikheraj17 eb26a61
comment out cloud SaaS parameters
ikheraj17 43b0ec2
Merge branch 'master' of https://github.com/ikheraj17/zeebe-dmn-worker
ikheraj17 e04e91b
Merge branch 'camunda-community-hub:master' into master
ikheraj17 332fdea
Fix tests
falko f126433
Remove clutter
falko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,134 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<definitions xmlns="https://www.omg.org/spec/DMN/20191111/MODEL/" xmlns:camunda="http://camunda.org/schema/1.0/dmn" id="definitions" name="definitions" namespace="http://camunda.org/schema/1.0/dmn" exporter="Camunda Modeler" exporterVersion="4.10.0-nightly.20210831"> | ||
<decision id="checkRisk_en" name="Risk Check"> | ||
<decisionTable id="decisionTable" hitPolicy="COLLECT"> | ||
<input id="input1" label="Age" camunda:inputVariable=""> | ||
<inputExpression id="inputExpression1" typeRef="integer" expressionLanguage="feel"> | ||
<text>age</text> | ||
</inputExpression> | ||
</input> | ||
<input id="InputClause_0sbc829" label="Employment"> | ||
<inputExpression id="LiteralExpression_0fpyor4" typeRef="string" expressionLanguage="feel"> | ||
<text>employment</text> | ||
</inputExpression> | ||
</input> | ||
<input id="InputClause_0ohc5m6" label="Category" camunda:inputVariable=""> | ||
<inputExpression id="LiteralExpression_0o7difo" typeRef="string" expressionLanguage="feel"> | ||
<text>category</text> | ||
</inputExpression> | ||
</input> | ||
<input id="InputClause_0g6gbjp" label="Score"> | ||
<inputExpression id="LiteralExpression_0zotgls" typeRef="integer" expressionLanguage="feel"> | ||
<text>score</text> | ||
</inputExpression> | ||
</input> | ||
<output id="output1" label="Risk" name="risk" typeRef="string" /> | ||
<output id="OutputClause_0hh62nv" label="Risk Level" name="riskLevel" typeRef="string" /> | ||
<rule id="DecisionRule_09dgf3c"> | ||
<description></description> | ||
<inputEntry id="UnaryTests_0ual6ir"> | ||
<text><= 30</text> | ||
</inputEntry> | ||
<inputEntry id="UnaryTests_1e397n3"> | ||
<text>-</text> | ||
</inputEntry> | ||
<inputEntry id="UnaryTests_0c3lrnz"> | ||
<text></text> | ||
</inputEntry> | ||
<inputEntry id="UnaryTests_1l0btob"> | ||
<text><=85</text> | ||
</inputEntry> | ||
<outputEntry id="LiteralExpression_1f3y5xd"> | ||
<text>"Won't Pay In Time"</text> | ||
</outputEntry> | ||
<outputEntry id="LiteralExpression_1w57ha5"> | ||
<text>"red"</text> | ||
</outputEntry> | ||
</rule> | ||
<rule id="DecisionRule_0s72fjf"> | ||
<description></description> | ||
<inputEntry id="UnaryTests_1dkokb9"> | ||
<text></text> | ||
</inputEntry> | ||
<inputEntry id="UnaryTests_0d5r6v3"> | ||
<text>"Unemployed"</text> | ||
</inputEntry> | ||
<inputEntry id="UnaryTests_1v6fey5"> | ||
<text>not("Basic Package")</text> | ||
</inputEntry> | ||
<inputEntry id="UnaryTests_1rw2hjn"> | ||
<text><=95</text> | ||
</inputEntry> | ||
<outputEntry id="LiteralExpression_18kpqx8"> | ||
<text>"Lack Of Income"</text> | ||
</outputEntry> | ||
<outputEntry id="LiteralExpression_0mrbkzr"> | ||
<text>"red"</text> | ||
</outputEntry> | ||
</rule> | ||
<rule id="DecisionRule_0c99hq3"> | ||
<description></description> | ||
<inputEntry id="UnaryTests_16q1ghi"> | ||
<text><= 30</text> | ||
</inputEntry> | ||
<inputEntry id="UnaryTests_0c86j25"> | ||
<text>"Self-employed"</text> | ||
</inputEntry> | ||
<inputEntry id="UnaryTests_0l8wmca"> | ||
<text>"Premium Package"</text> | ||
</inputEntry> | ||
<inputEntry id="UnaryTests_1qkgqif"> | ||
<text></text> | ||
</inputEntry> | ||
<outputEntry id="LiteralExpression_0jlpe55"> | ||
<text>"Irregular And Possibly Lack Of Income"</text> | ||
</outputEntry> | ||
<outputEntry id="LiteralExpression_05qilq2"> | ||
<text>"yellow"</text> | ||
</outputEntry> | ||
</rule> | ||
<rule id="DecisionRule_1euaw2y"> | ||
<description></description> | ||
<inputEntry id="UnaryTests_0bctfm4"> | ||
<text></text> | ||
</inputEntry> | ||
<inputEntry id="UnaryTests_12o8otd"> | ||
<text>"Freelancer", "Self-employed"</text> | ||
</inputEntry> | ||
<inputEntry id="UnaryTests_0o842fe"> | ||
<text>-</text> | ||
</inputEntry> | ||
<inputEntry id="UnaryTests_1h8e7id"> | ||
<text><=95</text> | ||
</inputEntry> | ||
<outputEntry id="LiteralExpression_1pwrw8z"> | ||
<text>"Not Trustworthy"</text> | ||
</outputEntry> | ||
<outputEntry id="LiteralExpression_0zcjpew"> | ||
<text>"yellow"</text> | ||
</outputEntry> | ||
</rule> | ||
<rule id="DecisionRule_08nz8pq"> | ||
<description></description> | ||
<inputEntry id="UnaryTests_0adgp9c"> | ||
<text></text> | ||
</inputEntry> | ||
<inputEntry id="UnaryTests_1jzpweh"> | ||
<text>"Salaried"</text> | ||
</inputEntry> | ||
<inputEntry id="UnaryTests_17itih0"> | ||
<text>"Premium Package"</text> | ||
</inputEntry> | ||
<inputEntry id="UnaryTests_0dgmj4d"> | ||
<text><90</text> | ||
</inputEntry> | ||
<outputEntry id="LiteralExpression_1xwbye7"> | ||
<text>"Too Low Income"</text> | ||
</outputEntry> | ||
<outputEntry id="LiteralExpression_1s5g29d"> | ||
<text>"yellow"</text> | ||
</outputEntry> | ||
</rule> | ||
</decisionTable> | ||
</decision> | ||
</definitions> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -245,4 +245,4 @@ | |
<tag>HEAD</tag> | ||
</scm> | ||
|
||
</project> | ||
</project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
/* | ||
* Copyright © 2017 camunda services GmbH ([email protected]) | ||
* Copyright © 2017 camunda services GmbH ([email protected]). | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
zeebe: | ||
client: | ||
# cloud: | ||
# clusterId: <YOUR_CLUSTER_ID> | ||
# clientId: <YOUR_CLIENT_ID> | ||
# clientSecret: <YOUR_CLIENT_SECRET> | ||
worker: | ||
defaultName: camunda-dmn-worker | ||
defaultType: DMN | ||
|
@@ -8,6 +12,7 @@ zeebe: | |
dmn.repository: dmn-repo | ||
|
||
job.timeout: 10000 | ||
# remove the following two lines when using Camunda Cloud SaaS | ||
broker.contactPoint: 127.0.0.1:26500 | ||
falko marked this conversation as resolved.
Show resolved
Hide resolved
|
||
security.plaintext: true | ||
|
||
|
@@ -20,3 +25,5 @@ logging: | |
management: | ||
server: | ||
port: 8081 | ||
|
||
server.port: 8082 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we can remove this config and use the default port. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ikheraj17 why do you want to add an example DMN to the repository?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So that users immediately see the folder in which files have to go and also have a working example in case they are new to DMN.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saig0 Are there any other outstanding issues regarding my pull request? If not, would you or the appropriate person please merge the changes that Falko and I have made? I'm in the process of creating documentation for the Camunda Cloud showcase, and the showcase's DMN functionality depends on this plugin. Please let me know if there are any other changes that you have questions about. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ikheraj17 I'm sorry for the delay. I was distracted by other duties 🙈
Currently, the build of this PR is failing. Something went wrong in the test case:
WorkflowTest.shouldCompleteWorkflowInstance()
.Are you able to build the PR locally?
I'll look into it today or tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can reproduce the test error locally. Looking into it...