-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook cannot implicitly connect to/launch runs in the Pipelines client #423
Comments
Workaround with PodDefault works for me, thanks! |
kubeflow/pipelines#5138 discusses this problem and some possible fixes. The fixes are not merged and the discussion seems stale but I'll see if I can revive anything. |
We can do kubeflow/pipelines#6629 ourselves (we already run a modified version of the Users still need to select that configuration button to get pipeline access in their notebook, but the situation would be better than it is now. Fixing/closing this issue should include a change to our documentation to instruct users about the button |
Nevermind, we can also make the trivial patch to our notebook spawner default config from kubeflow/kubeflow#6160 and the button is checked by default! |
This is part of the fix for canonical/bundle-kubeflow#423. This change automatically selects the "Allow access to Kubeflow Pipelines" PodDefault configuration for new notebooks, provided it has been already been added to the user's namespace. Adding the PodDefault is handled separately.
This change partly addresses canonical/bundle-kubeflow#423 This updates the kfp metacontroller managed by the kfp-profile-controller to add a new PodDefault to all user namespaces (Profiles). This PodDefault, when selected, lets Notebooks access the pipelines client without explicitly authenticating. The change here adds the PodDefault, but it does not automatically enable the kfp access. PodDefaults in a user's namespace are noticed by the notebook controller (charm: jupyter-ui) and shown to a user in the Notebook spawner UI under "Configurations". To enable this kfp integration, users must enable this new configuration "Allow access to Kubeflow Pipelines". This PodDefault can also be used by other workloads that might need access, such as a step of a pipeline. See the [admission-webhook readme](https://github.com/kubeflow/kubeflow/blob/master/components/admission-webhook/README.md) for more info.
This is part of the fix for canonical/bundle-kubeflow#423. This change automatically selects the "Allow access to Kubeflow Pipelines" PodDefault configuration for new notebooks, provided it has been already been added to the user's namespace. Adding the PodDefault is handled separately. Also changed: * remove unused environment variable from tests * fix integration testing by * pinning istio to 1.5 for tests * revert integration tests to use istio 1.5 * add test instructions in README.md * convert `kubectl` calls in tests to `lightkube` calls. * add patch to istio-ingressgateway role to fix bug with istio 1.5 charm * add automatic cleanup of non-juju created objects required for testing * deduplicating test runs
This is part of the fix for canonical/bundle-kubeflow#423. This change automatically selects the "Allow access to Kubeflow Pipelines" PodDefault configuration for new notebooks, provided it has been already been added to the user's namespace. Adding the PodDefault is handled separately. Also changed: * remove unused environment variable from tests * fix integration testing by * pinning istio to 1.5 for tests * revert integration tests to use istio 1.5 * add test instructions in README.md * convert `kubectl` calls in tests to `lightkube` calls. * add patch to istio-ingressgateway role to fix bug with istio 1.5 charm * add automatic cleanup of non-juju created objects required for testing * deduplicating test runs
This is part of the fix for canonical/bundle-kubeflow#423. This change automatically selects the "Allow access to Kubeflow Pipelines" PodDefault configuration for new notebooks, provided it has been already been added to the user's namespace. Adding the PodDefault is handled separately. Also changed: * remove unused environment variable from tests * fix integration testing by * pinning istio to 1.5 for tests * revert integration tests to use istio 1.5 * add test instructions in README.md * convert `kubectl` calls in tests to `lightkube` calls. * add patch to istio-ingressgateway role to fix bug with istio 1.5 charm * add automatic cleanup of non-juju created objects required for testing * deduplicating test runs
Closed by canonical/kfp-operators#49 and canonical/notebook-operators#24 |
Currently in a notebook, this does not work:
reporting:
I think this is because, when switching to multi-user isolation for pipelines, we missed adding this to the
PodDefault
s for each user.As a temporary workaround, used can from a terminal on cluster create a PodDefault in their namespace:
which will then enable new notebook servers to select KFP access in the
Configurations
section of the new notebook page.Another hack that will let you use kfp from an existing notebook is to copy your session cookie from your browser's development tools, then do:
The text was updated successfully, but these errors were encountered: