add a PodDefault for pipelines access to all Profiles #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change partly addresses canonical/bundle-kubeflow#423 This updates the kfp metacontroller managed by the kfp-profile-controller to add a new PodDefault to all user namespaces (Profiles). This PodDefault, when selected, lets Notebooks access the pipelines client without explicitly authenticating. The change here adds the PodDefault, but it does not automatically enable the kfp access. PodDefaults in a user's namespace are noticed by the notebook controller (charm: jupyter-ui) and shown to a user in the Notebook spawner UI under "Configurations". To enable this kfp integration, users must enable this new configuration "Allow access to Kubeflow Pipelines". This PodDefault can also be used by other workloads that might need access, such as a step of a pipeline. See the [admission-webhook readme](https://github.com/kubeflow/kubeflow/blob/master/components/admission-webhook/README.md) for more info.
DomFleischmann
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change partly addresses canonical/bundle-kubeflow#423
This updates the kfp metacontroller managed by the kfp-profile-controller to add a new PodDefault to all user namespaces (Profiles). This PodDefault, when selected, lets Notebooks access the pipelines client without explicitly authenticating.
The change here adds the PodDefault, but it does not automatically enable the kfp access. PodDefaults in a user's namespace are noticed by the notebook controller (charm: jupyter-ui) and shown to a user in the Notebook spawner UI under "Configurations". To enable this kfp integration, users must enable this new configuration "Allow access to Kubeflow Pipelines".
This PodDefault can also be used by other workloads that might need access, such as a step of a pipeline. See the admission-webhook readme for more info.