fix(22.04): fix arch specific paths for openjdk-8 #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjdcordeiro
force-pushed
the
22.04-fix-arch-openjdk
branch
from
c2691db
to
087970c
Compare
|
P.S. @rebornplusplus we need to start skipping in these cases as this is a false positive. |
|
Same as comment as #149 |
rebornplusplus
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Looks good to me, thanks!
P.S. @rebornplusplus we need to start skipping in these cases as this is a false positive.
Raised #151.
|
@linostar could you please have a look? Note that the failure is expected cause the pkg doesn't exist for that arch |
gregory-schiano
pushed a commit
to gregory-schiano/chisel-releases
that referenced
this pull request
Jun 22, 2024
cjdcordeiro
added a commit
to ozanmakes/chisel-releases
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain paths were not valid for all architectures. This PR adds the arch-specific constraints.
@vpa1977 can you pls double check if it makes sense?