-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(20.04): fix arch specific paths for openjdk-8 #150
fix(20.04): fix arch specific paths for openjdk-8 #150
Conversation
/client and /server hotspot machines could be built together and present in the same installation, though it is not something that openjdk-8 packaging does. |
when you say
can you please clarify? for |
I apologise for confusion. Yes, we build client for the armhf.
and move the client and server vm contents into separate slices. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I will let you guys sort out the organizing of files.
Ah...I see. We could do that indeed. It would be a refactoring task that I would address separately from this PR though, cause it would mean doing it for other releases too. See #152 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Same as #149
@vpa1977 can you also pls double check this one?