Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(20.04): fix arch specific paths for openjdk-8 #150

Merged

Conversation

cjdcordeiro
Copy link
Collaborator

Same as #149

@vpa1977 can you also pls double check this one?

@vpa1977
Copy link

vpa1977 commented Feb 25, 2024

/client and /server hotspot machines could be built together and present in the same installation, though it is not something that openjdk-8 packaging does.
Maybe would it be possible to split those into separate slices (if chisel allows) ?
Otherwise the change look fine.

@cjdcordeiro
Copy link
Collaborator Author

/client and /server hotspot machines could be built together and present in the same installation, though it is not something that openjdk-8 packaging does. Maybe would it be possible to split those into separate slices (if chisel allows) ? Otherwise the change look fine.

when you say

not something that openjdk-8 packaging does

can you please clarify? for armhf it seems that there's only client, while server is only available for other archs. Are you saying that, for armhf, the client should not be installed as part of the current slice?

@vpa1977
Copy link

vpa1977 commented Feb 26, 2024

can you please clarify? for armhf it seems that there's only client, while server is only available for other archs. Are you saying that, for armhf, the client should not be installed as part of the current slice?

I apologise for confusion. Yes, we build client for the armhf.
I was wondering if we can do something like:

slices:
  # The "core" slice provides a minimal, yet functional JRE8.
  core:
    essential:
      - libc6_libs
      - libgcc-s1_libs
      - libstdc++6_libs
      - zlib1g_libs
      - openjdk-8-jre-headless_client_vm
      - openjdk-8-jre-headless_server_vm

... 

and move the client and server vm contents into separate slices.

Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I will let you guys sort out the organizing of files.

slices/openjdk-8-jre-headless.yaml Outdated Show resolved Hide resolved
@cjdcordeiro
Copy link
Collaborator Author

can you please clarify? for armhf it seems that there's only client, while server is only available for other archs. Are you saying that, for armhf, the client should not be installed as part of the current slice?

I apologise for confusion. Yes, we build client for the armhf. I was wondering if we can do something like:

slices:
  # The "core" slice provides a minimal, yet functional JRE8.
  core:
    essential:
      - libc6_libs
      - libgcc-s1_libs
      - libstdc++6_libs
      - zlib1g_libs
      - openjdk-8-jre-headless_client_vm
      - openjdk-8-jre-headless_server_vm

... 

and move the client and server vm contents into separate slices.

Ah...I see. We could do that indeed. It would be a refactoring task that I would address separately from this PR though, cause it would mean doing it for other releases too. See #152

@cjdcordeiro cjdcordeiro self-assigned this Feb 27, 2024
Copy link
Collaborator

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cjdcordeiro cjdcordeiro merged commit 3272179 into canonical:ubuntu-20.04 Feb 28, 2024
@cjdcordeiro cjdcordeiro deleted the 20.04-fix-arch-openjdk branch February 28, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants