-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(22.04): add libgdiplus and its dependencies #307
feat(22.04): add libgdiplus and its dependencies #307
Conversation
Diff of dependencies: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall, thank you. Only left a comment below about the possibility of having conflicting paths.
Ran the CI too, the lint checks are failing. Please address those too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The files list is alright, it works too. But let me know what do you think about the suggested changes below. Perhaps we can use globs, but to a sub-directory level.
Co-authored-by: Rafid Bin Mostofa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
Left only a nitpick about the blank lines in multiple files. That shouldn't affect the merge though.
@cjdcordeiro I added the forward-porting PR to 24.04, will it be enough to get this guy a go? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for addressing the review comments and for a very neat PR description ;)
--------- Co-authored-by: Rafid Bin Mostofa <[email protected]>
Proposed changes
This PR adds libgdiplus slice as one of the deps for Mono System.Drawing package.
Following packages had been sliced for this:
File system emitted on the chiseling
Related issues/PRs
Forward porting
#314
Checklist