feat(24.04): libgdiplus and its dependencies #314
Conversation
|
Diff of dependencies: slices/fontconfig-config.yaml@@ -1,8 +1 @@
-fonts-croscore
fonts-dejavu-core
-fonts-freefont-otf
-fonts-freefont-ttf
-fonts-liberation
-fonts-noto-core
-fonts-texgyre
-fonts-urw-base35slices/fonts-urw-base35.yaml@@ -1 +0,0 @@
-xfonts-utilsslices/xfonts-encodings.yaml@@ -1 +0,0 @@
-x11-commonslices/xfonts-utils.yaml@@ -1,6 +1,5 @@
libc6
libfontenc1
libfreetype6
-x11-common
xfonts-encodings
zlib1g |
thecoldwine
force-pushed
the
ubuntu-24.04
branch
from
88244eb
to
29d5517
Compare
|
@cjdcordeiro @rebornplusplus can someone approve the workflow please? |
It's running. Must be a first time contributor thing that the workflows do not run automatically. Needs to looked into. |
There was a problem hiding this comment.
tyvm @thecoldwine ! This is a big one :)
Could you please:
- add the tests for
xdg-user-dirs,xfonts-utilsandfontconfig - comment of the dependency diff (especially the missing x11-common deps)
|
@cjdcordeiro I did push the deps update (I think), so it would be nice if we could run diff again. On the rest of comments I will redesign slices accordingly. |
|
@cjdcordeiro I pushed the changes, please have a look. Not sure who should resolve the conflicts. |
There was a problem hiding this comment.
Thanks @thecoldwine
The conflicts are in the files you're proposing. I suggest you do a rebase (cause some relevant changes have entered 24.04 since you opened your PR) and then you can fix each conflict individually.
P.S. the diff comment is updated on every commit.
thecoldwine
force-pushed
the
ubuntu-24.04
branch
2 times, most recently
from
c83a58d
to
d7f1d5b
Compare
|
Had to force push due to rebase. |
Co-authored-by: Cristovao Cordeiro <[email protected]>
| essential: | ||
| - fonts-noto-mono_fonts |
There was a problem hiding this comment.
Shouldn't the fonts-noto-core_config slice be listed as a dependency here?
There was a problem hiding this comment.
Any thoughts?
(Was this previously requested to be secluded?)
There was a problem hiding this comment.
@rebornplusplus not really — I can make a slice which will contain both of them, but in general @cjdcordeiro asked me to split packages to fonts and configs which do not depend on each other.
|
@rebornplusplus @cjdcordeiro please let me know if I need to address the changes in the PR or you will resolve them within the team. It feels like a full circle now, so I will wait for your signal for the action :D |
There was a problem hiding this comment.
Hiya, I marked most of my comments resolved per your response. There are still a few I would like your thoughts on.
Additionally, it seems like there are a few conflicts because the upstream has similar changes already. Could you please merge the upstream/main into this branch?
Thank you.
| essential: | ||
| - fonts-noto-mono_fonts |
There was a problem hiding this comment.
Any thoughts?
(Was this previously requested to be secluded?)
Sorry about the back and forth. I marked a few comments above for you to take another look at. Those are very trivial. Thus, once those are addressed, I can approve this and merge since Cris has approved it already. Thanks. :) |
thecoldwine
force-pushed
the
ubuntu-24.04
branch
from
9160b04
to
b77fb71
Compare
Co-authored-by: Rafid Bin Mostofa <[email protected]>
|
@rebornplusplus I updated the small changes, primary question is dependency in the font config, but it had been split intentionally after a review. |
Proposed changes
This PR adds libgdiplus slice as one of the deps for Mono System.Drawing package.
Following packages had been sliced for this:
File system emitted on the chiseling
Related issues/PRs
#307
Checklist
Additional Context