Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run the Spread tests with the LXD backend #317

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

cjdcordeiro
Copy link
Collaborator

@cjdcordeiro cjdcordeiro commented Aug 21, 2024

Proposed changes

Use the LXD backend instead of Docker. Thus we need to install and setup LXD and also run in amd64 and arm cause LXD will not have emulation, like Docker.

Related issues/PRs

#316

Checklist

See a test here: https://github.com/cjdcordeiro/chisel-releases/actions/runs/10492345808/job/29063655589?pr=17

@cjdcordeiro cjdcordeiro requested review from rebornplusplus and a team August 21, 2024 16:17
@cjdcordeiro cjdcordeiro added the Priority Look at me first label Aug 21, 2024
Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, looks good to me. Let's get this in!

Copy link
Collaborator

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Leaving one nitpick here.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@cjdcordeiro cjdcordeiro merged commit 845520b into canonical:main Aug 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority Look at me first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants