Add a default public-url config value
#123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change simplifies the setup for most (all?) OIDC+dex setups. By using the k8s-internal link to dex-auth rather than * adds the OIDC_AUTH_URL env var to OIDC, which lets OIDC redirect the user to dex via a relative link rather than the absolute OIDC_PROVIDER link * sets public-url (and thus OIDC_PROVIDER) to 'http://dex-auth.kubeflow.svc.cluster.local:5556' by default. Also adds special handling for k8s-internal urls since we typically append `/dex` to the public url for OIDC's inputs * Adds `AFTER_LOGIN_URL` to redirect all logins to the dashboard. This solves some corner cases where getting redirected to a login from a login page makes it seem to the user like they're in a login redirect loop even though they aren't. * Removes the `AFTER_LOGOUT_URL` which, if left out, defaults to a working value when the other env variables discussed above are set
This change simplifies the setup for most (all?) OIDC+dex setups. By using the k8s-internal link to dex-auth rather than * adds the OIDC_AUTH_URL env var to OIDC, which lets OIDC redirect the user to dex via a relative link rather than the absolute OIDC_PROVIDER link * sets public-url (and thus OIDC_PROVIDER) to 'http://dex-auth.kubeflow.svc.cluster.local:5556' by default. Also adds special handling for k8s-internal urls since we typically append `/dex` to the public url for OIDC's inputs * Adds `AFTER_LOGIN_URL` to redirect all logins to the dashboard. This solves some corner cases where getting redirected to a login from a login page makes it seem to the user like they're in a login redirect loop even though they aren't. * Removes the `AFTER_LOGOUT_URL` which, if left out, defaults to a working value when the other env variables discussed above are set
2 tasks
|
LGTM, but need to fix CI. |
43 tasks
|
Thanks @ca-scribner for the proposal. In the end this change will be slightly different. Please see #211 for more information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a default
public-urlconfig value as described in canonical/bundle-kubeflow#608. After implementing canonical/bundle-kubeflow#608 as a whole, we remove the need for users to modifypublic-url.While we could deprecate and remove the
public-urlconfig, it is recommended we leave it as is with this default. This is because in the medium term we plan on replacing dex+oidc with a different auth setup.