Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default public-url config value #123

Closed
wants to merge 2 commits into from

Commits on May 29, 2023

  1. add default k8s-internal value for public-url

    This change simplifies the setup for most (all?) OIDC+dex setups.  By using the k8s-internal link to dex-auth rather than
    * adds the OIDC_AUTH_URL env var to OIDC, which lets OIDC redirect the user to dex via a relative link rather than the absolute OIDC_PROVIDER link
    * sets public-url (and thus OIDC_PROVIDER) to 'http://dex-auth.kubeflow.svc.cluster.local:5556' by default.  Also adds special handling for k8s-internal urls since we typically append `/dex` to the public url for OIDC's inputs
    * Adds `AFTER_LOGIN_URL` to redirect all logins to the dashboard.  This solves some corner cases where getting redirected to a login from a login page makes it seem to the user like they're in a login redirect loop even though they aren't.
    * Removes the `AFTER_LOGOUT_URL` which, if left out, defaults to a working value when the other env variables discussed above are set
    ca-scribner committed May 29, 2023
    Configuration menu
    Copy the full SHA
    e3e4286 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. add default k8s-internal value for public-url

    This change simplifies the setup for most (all?) OIDC+dex setups.  By using the k8s-internal link to dex-auth rather than
    * adds the OIDC_AUTH_URL env var to OIDC, which lets OIDC redirect the user to dex via a relative link rather than the absolute OIDC_PROVIDER link
    * sets public-url (and thus OIDC_PROVIDER) to 'http://dex-auth.kubeflow.svc.cluster.local:5556' by default.  Also adds special handling for k8s-internal urls since we typically append `/dex` to the public url for OIDC's inputs
    * Adds `AFTER_LOGIN_URL` to redirect all logins to the dashboard.  This solves some corner cases where getting redirected to a login from a login page makes it seem to the user like they're in a login redirect loop even though they aren't.
    * Removes the `AFTER_LOGOUT_URL` which, if left out, defaults to a working value when the other env variables discussed above are set
    ca-scribner committed May 30, 2023
    Configuration menu
    Copy the full SHA
    7aae859 View commit details
    Browse the repository at this point in the history