Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: merge KF-5526-issuer-url-dev-branch into main #211

Merged
merged 4 commits into from
Jul 25, 2024
Merged

feat: merge KF-5526-issuer-url-dev-branch into main #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7fd5b15
feat: add dex_oidc_config library (#208)
DnPlas Jul 22, 2024
98ff8bf
refactor: add dex-issuer-url and remove public-url config options (#209)
DnPlas Jul 23, 2024
7954450
Update tests/unit/test_charm.py
DnPlas Jul 24, 2024
f94ada1
chore: keep public-url config option for compatibility (#213)
DnPlas Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charmcraft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ parts:
charm-python-packages: [setuptools, pip]
# Install rustc and cargo as build packages because some charm's
# dependencies need this to be built and installed from source.
build-packages: [rustc, cargo]
build-packages: [cargo, rustc, pkg-config, libffi-dev, libssl-dev]
23 changes: 19 additions & 4 deletions config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,22 @@ options:
type: boolean
default: true
description: Allows dex to keep a list of passwords which can be used to login to dex
issuer-url:
DnPlas marked this conversation as resolved.
Show resolved Hide resolved
type: string
default: ''
description: |
Format http(s)://<publicly-accessible-dns-name>/dex
(Also referred to as issuer or OIDC provider ) This is the canonical URL that OIDC clients
MUST use to refer to dex. If not specified, it defaults to dex-auth's local
endpoint constructed from dex-auth's Kubernetes Service DNS name, the
Service port and Dex's endpoint, that is http://<dex-auth-app-name>.<namespace>.svc:5556/dex.
The default is set by the charm code, not the configuration option.
This configuration must be set when using a Dex connector that will try to reach Dex from outside
the cluster, thus it should be a publicly accessible endpoint, for example https://my-instance.in-my-cloud.some-cloud.com/dex
port:
type: int
default: 5556
description: Listening port
public-url:
type: string
default: ''
description: Publicly-accessible endpoint for cluster
connectors:
type: string
default: ''
Expand All @@ -28,3 +36,10 @@ options:
type: string
default: ''
description: Static password for logging in without an external auth service
public-url:
type: string
default: ''
description: |
DEPRECATED - Please leave empty or use issuer-url instead. This configuration option will be removed soon.
It has been preserved to avoid breaking compatibility with existing deployments.
Publicly-accessible endpoint for cluster
Loading
Loading