Add istio control plane dashboard and alert rule #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The source of this dashboard is [1]. --- [1]: https://grafana.com/grafana/dashboards/7645-istio-control-plane-dashboard/
rgildein
commented
Jul 22, 2024
charms/istio-pilot/src/grafana_dashboards/istio_control_plane.json
Outdated
Show resolved
Hide resolved
After reading some article I think that rate was used here for good reason.
orfeas-k
reviewed
Jul 29, 2024
charms/istio-pilot/src/grafana_dashboards/istio_control_plane.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Orfeas Kourkakis <[email protected]>
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
Found some intteresting alert rules in [1], however based on istio doc [2], only the last one will work, so I added it here. --- [1]: https://samber.github.io/awesome-prometheus-alerts/rules#istio [2]: https://istio.io/latest/docs/reference/commands/pilot-discovery/#metrics
rgildein
changed the title
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: Out of sync
Libraries: OK
labels
rgildein
force-pushed
the
chore/KF-6033/dashboard
branch
from
4236793
to
99a6075
Compare
rgildein
force-pushed
the
chore/KF-6033/dashboard
branch
from
99a6075
to
a9919e3
Compare
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
rgildein
force-pushed
the
chore/KF-6033/dashboard
branch
from
a9919e3
to
94fa718
Compare
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
misohu
approved these changes
Aug 26, 2024
rgildein
added a commit
that referenced
this pull request
Aug 28, 2024
* Add istio control plane dashboard The source of this dashboard is [1]. --- [1]: https://grafana.com/grafana/dashboards/7645-istio-control-plane-dashboard/ * Add aler rule from source [1] based on metrics [2] Found some intteresting alert rules in [1], however based on istio doc [2], only the last one will work, so I added it here. --- [1]: https://samber.github.io/awesome-prometheus-alerts/rules#istio [2]: https://istio.io/latest/docs/reference/commands/pilot-discovery/#metrics
rgildein
added a commit
that referenced
this pull request
Aug 28, 2024
* Add istio control plane dashboard The source of this dashboard is [1]. --- [1]: https://grafana.com/grafana/dashboards/7645-istio-control-plane-dashboard/ * Add aler rule from source [1] based on metrics [2] Found some intteresting alert rules in [1], however based on istio doc [2], only the last one will work, so I added it here. --- [1]: https://samber.github.io/awesome-prometheus-alerts/rules#istio [2]: https://istio.io/latest/docs/reference/commands/pilot-discovery/#metrics
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dashboards
The source of this dashboard is 1.
I dropped two panels:
container_fs_usage_bytesmetricssidecar_injection_success_totalandsidecar_injection_failure_totalmetricsand did these changes:
app="istiod"tojuju-charm="istio-pilot"irateinstead ofratefor "Configuration Validation" panelgalley_validation_config_updatesandgalley_validation_config_update_errormetrics in "Configuration Validation" panel"sum(istio_build{component=\"pilot\"}) by (tag, juju_model)"podwith grouping byinstance, e.g.by (instance)blocked by: #477
To test this you need to have cos + garafana-agent deployed and integrate grafana-agent with istio-pilot via grafana-dashboard. After that you should be seen dashboard:
And dashboard should look like this:
Alert rules
I found some alert rules in this source 2, however after testing only the IstioPilotDuplicateEntry worked. This was due to missing metrics. Maybe we can enable more metrics, e.g. controller queue metrics with
ISTIO_ENABLE_CONTROLLER_QUEUE_METRICSenv 3, but this is out of scope of this PR.