Add metrics-endpoint to istio-gateway #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add relations endpoints + update manifest to export metrics via service port. fixes: #475
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: Out of sync
labels
There are more rules, but no metrics for them was found. I also cheded alert rules from [2]. The Grafana dashboards will be added to istio-pilot in different PR, since most of metrics used in them are from the istio-pilot. --- [1]: https://samber.github.io/awesome-prometheus-alerts/rules.html#rule-istio-1-10 [2]: https://github.com/istio/tools/blob/release-1.14/perf/stability/alertmanager/prometheusrule.yaml
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: OK
Libraries: Out of sync
labels
rgildein
added a commit
that referenced
this pull request
Jul 22, 2024
Add cos along with grafana_dashboard and prometheus_scrape, since this is related with #477.
Closed
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: OK
Libraries: Out of sync
labels
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: OK
Libraries: Out of sync
labels
github-actions
bot
added
Libraries: OK
and removed
Libraries: OK
Libraries: Out of sync
labels
orfeas-k
reviewed
Jul 30, 2024
rgildein
force-pushed
the
feat/KF-5996/metrics
branch
from
cacd0a4
to
73289d9
Compare
orfeas-k
previously approved these changes
Jul 30, 2024
rgildein
changed the title
rgildein
force-pushed
the
feat/KF-5996/metrics
branch
from
239d4dd
to
6dd4efb
Compare
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: OK
Libraries: Out of sync
labels
orfeas-k
approved these changes
Jul 31, 2024
rgildein
added a commit
that referenced
this pull request
Aug 28, 2024
Add relations endpoints + update manifest to export metrics via service port. There are more rules, but no metrics for them was found. I also cheded alert rules from [2]. The Grafana dashboards will be added to istio-pilot in different PR, since most of metrics used in them are from the istio-pilot. --- [1]: https://samber.github.io/awesome-prometheus-alerts/rules.html#rule-istio-1-10 [2]: https://github.com/istio/tools/blob/release-1.14/perf/stability/alertmanager/prometheusrule.yaml
rgildein
added a commit
that referenced
this pull request
Aug 28, 2024
Add relations endpoints + update manifest to export metrics via service port. There are more rules, but no metrics for them was found. I also cheded alert rules from [2]. The Grafana dashboards will be added to istio-pilot in different PR, since most of metrics used in them are from the istio-pilot. --- [1]: https://samber.github.io/awesome-prometheus-alerts/rules.html#rule-istio-1-10 [2]: https://github.com/istio/tools/blob/release-1.14/perf/stability/alertmanager/prometheusrule.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add relations endpoints for metrics and Grafana dashboards + update manifest to export metrics via service port. I add separate service port, since
ClusterIPis enough for metrics.I also update cos-integration test for both charms using only chisme cos abstraction. For testing if alert rule is firing, we should use promtool.
fixes: #475