Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rewrite the Tensorboards Web App charm following the sidecar pattern #74

Merged
merged 28 commits into from
Jun 28, 2023

Commits on Jun 22, 2023

  1. pip: Update fmt and lint requirements

    Update pip packages' versions with `tox -e update-requirements`.
    orfeas-k committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    0530cdc View commit details
    Browse the repository at this point in the history
  2. files: Add VSCode files to .gitignore

    Modify .gitignore in order to ignore any .VSCode directory.
    orfeas-k committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    c4e47ee View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b5fd1ad View commit details
    Browse the repository at this point in the history
  4. files(twa): Introduce CONTRIBUTING.md file

    Introduce CONTRIBUTING.md file with essential instructions for
    contributing to the charm's code.
    orfeas-k committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    ca03117 View commit details
    Browse the repository at this point in the history
  5. manifests(twa): Add upstream manifests as templates

    Generate upstream Tensorboards Web App manifests and keep the relevant
    parts as Jinja2 templates.
    orfeas-k committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    7d97313 View commit details
    Browse the repository at this point in the history
  6. pip(twa): Update fmt and lint requirements

    Update pip packages' versions with `tox -e update-requirements`.
    orfeas-k committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    401405d View commit details
    Browse the repository at this point in the history
  7. twa: Add _log_and_set_status() function

    Add _log_and_set_status(), which is a copy from the function of the same
    name in istio-pilot charm.
    orfeas-k committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    f23fc89 View commit details
    Browse the repository at this point in the history
  8. twa: Block charm if there is no ingress relation

    Modify configure_mesh() function to set status to `blocked` when there
    is no ingress relation available. We decided upon this behaviour since
    as a web app charm, it will be useless if it cannot be accessed.
    orfeas-k committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    68357c7 View commit details
    Browse the repository at this point in the history
  9. twa: Rewrite charm with sidecar pattern

    - Rewrite charm following the sidecar pattern and using Pebble to manage
      the workload. Jupyter-UI charm was used as an example for this rewrite.
    - Modify metadata.yaml to:
       - add a container
       - include information like website, source, docs, description
       - modify oci-image name
    - Import KubernetesServicePatch library using `charmcraft fetch-lib`.
    orfeas-k committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    d40bb2c View commit details
    Browse the repository at this point in the history
  10. tests: Fix joint charms deploy test

    - Pin juju in requirements-integration file to ensure compatibility with
      controller version 2.9.
    - Modify image-path and resources to reflect changes in the
      metadata.yaml of TWA charm.
    - Deploy TWA with trust=True argument.
    - Update test to relate TWA and istio-pilot charms with ingress relation
      in order to avoid TWA charm from getting in `blocked` status.
    orfeas-k committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    0cbd3ea View commit details
    Browse the repository at this point in the history
  11. tests(twa): Rewrite TWA unit tests

    - Update requirements-unit files
    - Modify tox.ini unit tests command
    - Write tests to check that:
      - charm waits if it's not the leader
      - charm is blocked when there is no ingress relation.
      - charm is active when there is an ingress relation
      - Pebble layer is created with expected values
      - K8S resource handler is executed as expected
    orfeas-k committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    9fabb37 View commit details
    Browse the repository at this point in the history
  12. tests(twa): Add integration tests for TWA

     - Introduce integration environment in tox.ini file
     - Create requirements-integration files
     - Write tests to check that:
        - charm is built and deployed with expected status
        - unit's status changes when charm is related with istio-pilot:ingress
        - TWA's UI is accessible through its address:port
    orfeas-k committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    f32b718 View commit details
    Browse the repository at this point in the history
  13. files: Update README.md deploy instructions

    - Istio-pilot's gateway relation was renamed to gateway-info. See
    canonical/istio-operators#112
    - Both Tensorboards charms are rewritten following the sidecar pattern
    and need to be `juju` deployed with `--trust` argument.
    orfeas-k committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    03768bd View commit details
    Browse the repository at this point in the history
  14. pip(twa): Bump SDI package's version

    Bump SDI version by removing pin in all requirements files
    orfeas-k committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    52211dd View commit details
    Browse the repository at this point in the history
  15. files: Add last lines

    orfeas-k committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    fa5b328 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    bbfddee View commit details
    Browse the repository at this point in the history
  17. fixup! twa: Rewrite charm with sidecar pattern

    - Use K8sResourceHandler with labels and resource types arguments
    - Modify pebble check name
    - Fetch container name from metadata.yaml
    orfeas-k committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    e68b8f6 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    6650cf7 View commit details
    Browse the repository at this point in the history
  19. config(twa): Drop TWA container port

    Stop exposing the Tensorboards Web App's 'containerPort' as configurable
    through the charm's config. This is neither an option likely to be
    required by the end-user, nor actually supported by the WA itself.
    orfeas-k committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    b41d159 View commit details
    Browse the repository at this point in the history
  20. config(twa): Backend-mode defaults to 'production'

    When deploying Kubeflow, all web apps should use `production` mode to
    ensure proper user authentication. Otherwise, every user is being
    treated as admin. See kubeflow/kubeflow#5566
    orfeas-k committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    265ec3e View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    9c0f66c View commit details
    Browse the repository at this point in the history
  22. tests(twa): Lint unit tests

    orfeas-k committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    874c1f2 View commit details
    Browse the repository at this point in the history
  23. tests(twa): Adapt integration tests to production mode

    Add headers to the request sent during integration tests in order to be
    able to fetch the TWA's UI.
    orfeas-k committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    15d571a View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. fixup! twa: Rewrite charm with sidecar pattern

    - Modify on_remove to use krh.delete() function
    - Rename err to error in all instances
    - Remove container connection check since it is done by update_layer()
    - Set status in _on_event instead of _configure_mesh()
    - Stop logging inside check_leader
    orfeas-k committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    35a05b0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d37f702 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Configuration menu
    Copy the full SHA
    a98dc2c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8d06d32 View commit details
    Browse the repository at this point in the history
  3. twa: Modify charm message when there is no ingress relation

    Modify charm message when there is no ingress relation available.
    orfeas-k committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    6b3c749 View commit details
    Browse the repository at this point in the history