-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Rewrite the Tensorboards Web App charm following the sidecar pattern #74
Commits on Jun 22, 2023
-
pip: Update fmt and lint requirements
Update pip packages' versions with `tox -e update-requirements`.
Configuration menu - View commit details
-
Copy full SHA for 0530cdc - Browse repository at this point
Copy the full SHA 0530cdcView commit details -
files: Add VSCode files to .gitignore
Modify .gitignore in order to ignore any .VSCode directory.
Configuration menu - View commit details
-
Copy full SHA for c4e47ee - Browse repository at this point
Copy the full SHA c4e47eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5fd1ad - Browse repository at this point
Copy the full SHA b5fd1adView commit details -
files(twa): Introduce CONTRIBUTING.md file
Introduce CONTRIBUTING.md file with essential instructions for contributing to the charm's code.
Configuration menu - View commit details
-
Copy full SHA for ca03117 - Browse repository at this point
Copy the full SHA ca03117View commit details -
manifests(twa): Add upstream manifests as templates
Generate upstream Tensorboards Web App manifests and keep the relevant parts as Jinja2 templates.
Configuration menu - View commit details
-
Copy full SHA for 7d97313 - Browse repository at this point
Copy the full SHA 7d97313View commit details -
pip(twa): Update fmt and lint requirements
Update pip packages' versions with `tox -e update-requirements`.
Configuration menu - View commit details
-
Copy full SHA for 401405d - Browse repository at this point
Copy the full SHA 401405dView commit details -
twa: Add _log_and_set_status() function
Add _log_and_set_status(), which is a copy from the function of the same name in istio-pilot charm.
Configuration menu - View commit details
-
Copy full SHA for f23fc89 - Browse repository at this point
Copy the full SHA f23fc89View commit details -
twa: Block charm if there is no ingress relation
Modify configure_mesh() function to set status to `blocked` when there is no ingress relation available. We decided upon this behaviour since as a web app charm, it will be useless if it cannot be accessed.
Configuration menu - View commit details
-
Copy full SHA for 68357c7 - Browse repository at this point
Copy the full SHA 68357c7View commit details -
twa: Rewrite charm with sidecar pattern
- Rewrite charm following the sidecar pattern and using Pebble to manage the workload. Jupyter-UI charm was used as an example for this rewrite. - Modify metadata.yaml to: - add a container - include information like website, source, docs, description - modify oci-image name - Import KubernetesServicePatch library using `charmcraft fetch-lib`.
Configuration menu - View commit details
-
Copy full SHA for d40bb2c - Browse repository at this point
Copy the full SHA d40bb2cView commit details -
tests: Fix joint charms deploy test
- Pin juju in requirements-integration file to ensure compatibility with controller version 2.9. - Modify image-path and resources to reflect changes in the metadata.yaml of TWA charm. - Deploy TWA with trust=True argument. - Update test to relate TWA and istio-pilot charms with ingress relation in order to avoid TWA charm from getting in `blocked` status.
Configuration menu - View commit details
-
Copy full SHA for 0cbd3ea - Browse repository at this point
Copy the full SHA 0cbd3eaView commit details -
tests(twa): Rewrite TWA unit tests
- Update requirements-unit files - Modify tox.ini unit tests command - Write tests to check that: - charm waits if it's not the leader - charm is blocked when there is no ingress relation. - charm is active when there is an ingress relation - Pebble layer is created with expected values - K8S resource handler is executed as expected
Configuration menu - View commit details
-
Copy full SHA for 9fabb37 - Browse repository at this point
Copy the full SHA 9fabb37View commit details -
tests(twa): Add integration tests for TWA
- Introduce integration environment in tox.ini file - Create requirements-integration files - Write tests to check that: - charm is built and deployed with expected status - unit's status changes when charm is related with istio-pilot:ingress - TWA's UI is accessible through its address:port
Configuration menu - View commit details
-
Copy full SHA for f32b718 - Browse repository at this point
Copy the full SHA f32b718View commit details -
files: Update README.md deploy instructions
- Istio-pilot's gateway relation was renamed to gateway-info. See canonical/istio-operators#112 - Both Tensorboards charms are rewritten following the sidecar pattern and need to be `juju` deployed with `--trust` argument.
Configuration menu - View commit details
-
Copy full SHA for 03768bd - Browse repository at this point
Copy the full SHA 03768bdView commit details -
pip(twa): Bump SDI package's version
Bump SDI version by removing pin in all requirements files
Configuration menu - View commit details
-
Copy full SHA for 52211dd - Browse repository at this point
Copy the full SHA 52211ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa5b328 - Browse repository at this point
Copy the full SHA fa5b328View commit details -
Configuration menu - View commit details
-
Copy full SHA for bbfddee - Browse repository at this point
Copy the full SHA bbfddeeView commit details -
fixup! twa: Rewrite charm with sidecar pattern
- Use K8sResourceHandler with labels and resource types arguments - Modify pebble check name - Fetch container name from metadata.yaml
Configuration menu - View commit details
-
Copy full SHA for e68b8f6 - Browse repository at this point
Copy the full SHA e68b8f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6650cf7 - Browse repository at this point
Copy the full SHA 6650cf7View commit details -
config(twa): Drop TWA container port
Stop exposing the Tensorboards Web App's 'containerPort' as configurable through the charm's config. This is neither an option likely to be required by the end-user, nor actually supported by the WA itself.
Configuration menu - View commit details
-
Copy full SHA for b41d159 - Browse repository at this point
Copy the full SHA b41d159View commit details -
config(twa): Backend-mode defaults to 'production'
When deploying Kubeflow, all web apps should use `production` mode to ensure proper user authentication. Otherwise, every user is being treated as admin. See kubeflow/kubeflow#5566
Configuration menu - View commit details
-
Copy full SHA for 265ec3e - Browse repository at this point
Copy the full SHA 265ec3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c0f66c - Browse repository at this point
Copy the full SHA 9c0f66cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 874c1f2 - Browse repository at this point
Copy the full SHA 874c1f2View commit details -
tests(twa): Adapt integration tests to
production
modeAdd headers to the request sent during integration tests in order to be able to fetch the TWA's UI.
Configuration menu - View commit details
-
Copy full SHA for 15d571a - Browse repository at this point
Copy the full SHA 15d571aView commit details
Commits on Jun 23, 2023
-
fixup! twa: Rewrite charm with sidecar pattern
- Modify on_remove to use krh.delete() function - Rename err to error in all instances - Remove container connection check since it is done by update_layer() - Set status in _on_event instead of _configure_mesh() - Stop logging inside check_leader
Configuration menu - View commit details
-
Copy full SHA for 35a05b0 - Browse repository at this point
Copy the full SHA 35a05b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d37f702 - Browse repository at this point
Copy the full SHA d37f702View commit details
Commits on Jun 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a98dc2c - Browse repository at this point
Copy the full SHA a98dc2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d06d32 - Browse repository at this point
Copy the full SHA 8d06d32View commit details -
twa: Modify charm message when there is no ingress relation
Modify charm message when there is no ingress relation available.
Configuration menu - View commit details
-
Copy full SHA for 6b3c749 - Browse repository at this point
Copy the full SHA 6b3c749View commit details