feat: Rewrite the Tensorboards Web App charm following the sidecar pattern #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: OK
labels
orfeas-k
force-pushed
the
orfeas-twa-rewrite-sidecar
branch
from
12ec345
to
e4e6c0a
Compare
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
orfeas-k
force-pushed
the
orfeas-twa-rewrite-sidecar
branch
from
e4e6c0a
to
8d91647
Compare
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
orfeas-k
changed the title
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
|
Extremely pedantic suggestion for the upgrade instructions :) should be Doesn't change the function, but gets the terminology consistent with elsewhere. |
ca-scribner
approved these changes
Jun 15, 2023
charms/tensorboards-web-app/src/templates/auth_manifests.yaml.j2
Outdated
Show resolved
Hide resolved
ca-scribner
suggested changes
Jun 15, 2023
orfeas-k
added a commit
to canonical/kubeflow-roles-operator
that referenced
this pull request
Jun 19, 2023
Remove tensorboards-web-app aggregation roles since TWA charm now follows the sidecar pattern with Pebble and can apply aggregation roles itself. See canonical/kubeflow-tensorboards-operator#74
ca-scribner
previously approved these changes
Jun 23, 2023
- Modify on_remove to use krh.delete() function - Rename err to error in all instances - Remove container connection check since it is done by update_layer() - Set status in _on_event instead of _configure_mesh() - Stop logging inside check_leader
orfeas-k
force-pushed
the
orfeas-twa-rewrite-sidecar
branch
from
fb16824
to
d37f702
Compare
kimwnasptd
reviewed
Jun 24, 2023
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: OK
Libraries: Out of sync
labels
Modify charm message when there is no ingress relation available.
orfeas-k
force-pushed
the
orfeas-twa-rewrite-sidecar
branch
from
e27861e
to
6b3c749
Compare
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: OK
Libraries: Out of sync
labels
orfeas-k
added a commit
to canonical/kubeflow-roles-operator
that referenced
this pull request
Jun 28, 2023
Remove tensorboards-web-app aggregation roles since TWA charm now follows the sidecar pattern with Pebble and can apply aggregation roles itself. See canonical/kubeflow-tensorboards-operator#74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the Tensorboards Web App (TWA) charm following the sidecar pattern
In short:
productionas default for config's Backend-modeUpgrade instructions
i. the image since
oci-imagewas changed totensorboards-web-app-image.ii. the path to the local charm or the corresponding channel (for charms released in charmhub)
or