Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxc: allow creation of various resources from YAML (from Incus) #13995

Merged
merged 17 commits into from
Sep 3, 2024
Merged

lxc: allow creation of various resources from YAML (from Incus) #13995

merged 17 commits into from
Sep 3, 2024

Conversation

gabrielmougard
Copy link
Contributor

cherry-picked from: lxc/incus#786
cherry-picked from: lxc/incus#782
cherry-picked from: lxc/incus#778
cherry-picked from: lxc/incus#775
cherry-picked from: lxc/incus#767
cherry-picked from: lxc/incus#863
cherry-picked from: lxc/incus#864
cherry-picked from: lxc/incus#891

@gabrielmougard gabrielmougard self-assigned this Aug 28, 2024
@gabrielmougard gabrielmougard mentioned this pull request Aug 28, 2024
Merged
2 tasks
@gabrielmougard
Copy link
Contributor Author

gabrielmougard commented Aug 28, 2024 •
edited
Loading

I guess the cluster test suite iis broken because of the new dqlite ppa? The rest of the tests seem ok.

tomponline
tomponline requested changes Aug 28, 2024
View reviewed changes
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabrielmougard before I go any further, please can you go through this PR (and your earlier related ones) and double check that the whole of the Put data being read in is actually being applied, and that the name of the resource isn't being overridden from stdin too, as it looks like at least some of these cherry-picks are only taking the Config from the Put structure and not things like Description.

@gabrielmougard gabrielmougard force-pushed the incus/rest-of-yaml-pr branch 3 times, most recently from c59bce0 to 39eecc0 Compare August 29, 2024 14:35
@gabrielmougard
Copy link
Contributor Author

@gabrielmougard before I go any further, please can you go through this PR (and your earlier related ones) and double check that the whole of the Put data being read in is actually being applied, and that the name of the resource isn't being overridden from stdin too, as it looks like at least some of these cherry-picks are only taking the Config from the Put structure and not things like Description.

It should be fixed now. I also opened this related issue: #14011

@tomponline
Copy link
Member

@gabrielmougard did you also review your earlier PRs https://github.com/canonical/lxd/pulls?q=is%3Apr+is%3Aclosed+author%3Agabrielmougard+lxc for similar issues that I missed before?

tomponline
tomponline reviewed Aug 30, 2024
View reviewed changes
lxc/storage.go Outdated Show resolved Hide resolved
tomponline
tomponline reviewed Aug 30, 2024
View reviewed changes
lxc/snapshot.go Outdated Show resolved Hide resolved
@gabrielmougard
Copy link
Contributor Author

@tomponline is it possible to review and merge that PR before merging this PR?

@gabrielmougard
Copy link
Contributor Author

@gabrielmougard did you also review your earlier PRs https://github.com/canonical/lxd/pulls?q=is%3Apr+is%3Aclosed+author%3Agabrielmougard+lxc for similar issues that I missed before?

@tomponline After reading these past PRs, I noticed I missed adding a description field in the test commit of #13923 and check it has been applied... Shall I fix this in this PR? The rest of the past PRs look fine to me.

@tomponline
Copy link
Member

@tomponline After reading these past PRs, I noticed I missed adding a description field in the test commit of #13923 and check it has been applied... Shall I fix this in this PR? The rest of the past PRs look fine to me.

Yes please

awalvie and others added 5 commits August 30, 2024 14:08
@awalvie @gabrielmougard
lxc/network_forward: Add yaml example for create
4761126 
`lxc network forward create` already has support for creation from a
yaml configuration file, but the same wasn't printed in the usage
information of the command.

Signed-off-by: Vishesh Agrawal <[email protected]>
(cherry picked from commit 07395fa051955611579148c76cd5ab4aed13e041)
Signed-off-by: Gabriel Mougard <[email protected]>
License: Apache-2.0
@awalvie @gabrielmougard
lxc/network_acl: Add cmd.Example for network acl create
a48a9c8 
`lxc network acl create` already has support for creation from a yaml
configuration file, but the same wasn't printed in the usage information
of the command.

Signed-off-by: Vishesh Agrawal <[email protected]>
(cherry picked from commit e728bf77ff7f58cdd14bcb78acb519056ab6f5ad)
Signed-off-by: Gabriel Mougard <[email protected]>
License: Apache-2.0
@gabrielmougard
lxc/network_acl: fix go-vet linter errors
03962be 
Signed-off-by: Gabriel Mougard <[email protected]>
@gabrielmougard
lxc/network_forward: fix go-vet linter errors
fdb598e 
Signed-off-by: Gabriel Mougard <[email protected]>
@awalvie @gabrielmougard
lxc/cluster_group: Add yaml support for cluster group create
1a90984 
Signed-off-by: Vishesh Agrawal <[email protected]>
(cherry picked from commit c64a3f39f2556a86a2b58f95eeaba0c1b57ea5ad)
Signed-off-by: Gabriel Mougard <[email protected]>
License: Apache-2.0
@gabrielmougard gabrielmougard force-pushed the incus/rest-of-yaml-pr branch 5 times, most recently from c0c4ea4 to a15a0e4 Compare September 2, 2024 16:48
gabrielmougard and others added 11 commits September 2, 2024 19:03
@gabrielmougard
test: Create a cluster group using YAML
a361cb6 
Signed-off-by: Gabriel Mougard <[email protected]>
@awalvie @gabrielmougard
lxc/storage: Support creating storage pool from yaml
8f0a4b2 
Signed-off-by: Vishesh Agrawal <[email protected]>
(cherry picked from commit 0864637abefc63a55f516f598a4c2f1581f52a87)
Signed-off-by: Gabriel Mougard <[email protected]>
License: Apache-2.0
Signed-off-by: Gabriel Mougard <[email protected]>
@gabrielmougard
lxc/storage: fix go-vet linter errors
251a488 
Signed-off-by: Gabriel Mougard <[email protected]>
@gabrielmougard
test: Test creating a storage pool with a YAML config
19b98b9 
Signed-off-by: Gabriel Mougard <[email protected]>
@awalvie @gabrielmougard
lxc/network_zone: Add example for network zone record create
6775979 
Signed-off-by: Vishesh Agrawal <[email protected]>
(cherry picked from commit 58dc074fbad8d7049f4a52c7c3c0685fd72f856f)
Signed-off-by: Gabriel Mougard <[email protected]>
License: Apache-2.0
@gabrielmougard
lxc/snapshot: Add support for creating a snapshot with YAML config
f18ffd1 
Signed-off-by: Vishesh Agrawal <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
License: Apache-2.0
Signed-off-by: Gabriel Mougard <[email protected]>
@gabrielmougard
test: Add test for creating a snapshot using a YAML configuration
faff002 
Signed-off-by: Gabriel Mougard <[email protected]>
@awalvie @gabrielmougard
lxc/storage_volume: Add yaml support for create
19cd242 
Signed-off-by: Vishesh Agrawal <[email protected]>
(cherry picked from commit d42cd0136dca95c1e9cb78d5a0438e215efe3ece)
Signed-off-by: Gabriel Mougard <[email protected]>
License: Apache-2.0
Signed-off-by: Gabriel Mougard <[email protected]>
@gabrielmougard
test: Add test for creating a volume using YAAML config
6c4953c 
Signed-off-by: Gabriel Mougard <[email protected]>
@gabrielmougard
test: Add missing description to bucket key
cb010e8 
We need to check that when a bucket key is created with a description,
the description is saved correctly to the DB.

Signed-off-by: Gabriel Mougard <[email protected]>
@gabrielmougard
i18n: update translation templates
4edd778 
Signed-off-by: Gabriel Mougard <[email protected]>
tomponline
tomponline approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomponline tomponline merged commit 495e793 into canonical:main Sep 3, 2024
28 of 29 checks passed
@simondeziel simondeziel mentioned this pull request Sep 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomponline tomponline Awaiting requested review from tomponline

Assignees

@gabrielmougard gabrielmougard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrielmougard @tomponline @awalvie