Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make lxd-agent install script compatible with SUSE #14003

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Make lxd-agent install script compatible with SUSE #14003

merged 4 commits into from
Sep 3, 2024

Conversation

simondeziel
Copy link
Member

Fixes #13991

@simondeziel
Copy link
Member Author

This was tested on Ubuntu 24.04, OpenSUSE 15.6 and Tumbleweed. Note that Tumbleweed has a compat symlink in place (/lib/ -> /usr/lib/) so didn't need the fix anyway.

To test this, I used ubuntu-minimal-daily:24.04, images:opensuse/15.6 and images:opensuse/tumbleweed VMs where:

  1. setup SSH
  2. removed every traces of the LXD agent
  3. rebooted
  4. confirmed agent not working
  5. mounted the virtiofs config share onto /mnt
  6. copied the install.sh script on the VM
  7. mount bind the install.sh script onto /mnt/install.sh
  8. manually installed the agent
  9. rebooted
  10. confirmed the agent worked

I also tested this on a manually installed VM running SUSE 15 SP6 (ISO install).

@simondeziel simondeziel marked this pull request as ready for review August 28, 2024 20:23
@simondeziel simondeziel mentioned this pull request Aug 28, 2024
Merged
tomponline added a commit that referenced this pull request Aug 29, 2024
@tomponline
doc/guest-os-compatibility: add SUSE 12 and 15 (#14005)
39452a7 
This assumed #14003 will be backported to `5.21/stable`.
@simondeziel simondeziel force-pushed the lxd-agent-suse-guests branch 2 times, most recently from 8f623dd to 8a6e6d6 Compare August 30, 2024 21:11
@simondeziel
lxd/instance/drivers/qemu: update how systemd is detected
a063b1a 
https://www.freedesktop.org/software/systemd/man/latest/sd_booted.html:
> Internally, this function checks whether the directory /run/systemd/system/
> exists. A simple check like this can also be implemented trivially in shell
> or any other language.

Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
lxd/instance/drivers/qemu: compat with SUSE paths
9a2f6e6 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
doc/guest-os-compatibility: improve legend readability
96b0f69 
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel
doc/guest-os-compatibility: link to how to install lxd-agent manually
6d41293 
Signed-off-by: Simon Deziel <[email protected]>
@github-actions github-actions bot added the Documentation Documentation needs updating label Sep 3, 2024
@simondeziel
Copy link
Member Author

simondeziel commented Sep 3, 2024 •
edited
Loading

@tomponline the CI fails for what seems to be a regression with microceph as it's consistently failing in this unrelated spot: https://github.com/canonical/lxd/actions/runs/10685425570/job/29621723179#step:12:50510

Update: this is not a regression in microceph but one in LXD introduced by #13995

@tomponline tomponline merged commit e219ff7 into canonical:main Sep 3, 2024
28 of 29 checks passed
@simondeziel simondeziel deleted the lxd-agent-suse-guests branch September 3, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomponline tomponline tomponline approved these changes

@markylaing markylaing markylaing left review comments

Assignees
No one assigned
Labels
Documentation Documentation needs updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lxd-agent not compatible with SLES 12/15 due path differences
3 participants
@simondeziel @tomponline @markylaing