Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use juju 3.4/stable instead of 3.5/stable in track 1.17 #258

Closed
wants to merge 11 commits into from

Commits on Nov 27, 2023

  1. Update GH files for issue templates and Jira automation (#227)

    This PR updates the .github files to
    * Ensure we have a file for tasks/enhancements
    * Ensure we expose dod in task issues
    * Use the FastAPI for ticket sync, and not JIRA_URL
    kimwnasptd authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    e015898 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. feat: Configure test_seldon_servers integration tests to be splitable (

    …#228)
    
    - tests(integration): Configure test_seldon_servers test in order to be able 
      to run tests only on one of the SeldonDeployments CRs. This can be done 
      using pytest's-k flag and the corresponding keyword. You can find keywords 
      in CONTRIBUTING.md or by looking at the id field of seldon_servers.py objects.
    - tests(integration): Remove limits from SeldonDeployments applied.
    - Update CONTRIBUTING.md with instructions on how to run tests separately.
    - ci: Run test_seldon_servers integration test for each SeldonDeployment CR 
      in a distinct GH runner. 
    - ci: Extract automatically tox integration environments using a script.
    
    Fixes #229
    orfeas-k authored Dec 4, 2023
    Configuration menu
    Copy the full SHA
    3b8bb88 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Update task template (#231)

    update the task template to also include context and dod.
    kimwnasptd authored Dec 13, 2023
    Configuration menu
    Copy the full SHA
    9cb5d9c View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. feat: Integrate ROCKs to charm and servers (#232)

    * Use ROCKs for charm and predictor servers
    
    * Update test data to expect ROCKs
    
    * fix: Use updated tensorflow-serving ROCK
    
    * tests: Update test results according to ROCK
    orfeas-k authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    b9e9ac3 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Configuration menu
    Copy the full SHA
    4df407f View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. fix: correct metrics path for MetricsEndpointProvider (#236)

    * fix: correctly configure one scrape job to avoid firig alerts
    
    The metrics endpoint configuration had two scrape jobs, one for the
    regular metrics endpoint, and a second one based on a dynamic list of
    targets. The latter was causing the prometheus scraper to try and scrape
    metrics from *:80/metrics, which is not a valid endpoint. This was
    causing the UnitsUnavailable alert to fire constantly because that job
    was reporting back that the endpoint was not available.
    This new job was introduced by #94
    with no apparent justification. Because the seldon charm has changed
    since that PR, and the endpoint it is configuring is not valid, this
    commit will remove the extra job.
    
    This commit also refactors the MetricsEndpointProvider instantiation and
    removes the metrics-port config option as this value should not change.
    
    Finally, this commit changes the alert rule interval from 0m to 5m, as
    this interval is more appropriate for production environments.
    
    Part of canonical/bundle-kubeflow#564
    
    * tests: add an assertion for checking unit is available
    
    The test_prometheus_grafana_integration test case was doing queries to prometheus
    and checking the request returned successfully and that the application name and model
    was listed correctly. To make this test case more accurately, we can add an assertion that
    also checks that the unit is available, this way we avoid issues like the one described in
    canonical/bundle-kubeflow#564.
    
    Part of canonical/bundle-kubeflow#564
    DnPlas authored Feb 13, 2024
    Configuration menu
    Copy the full SHA
    1d1a6f5 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. tests: add a retry when asserting the up metric (#243)

    * tests: add a retry when asserting the up metric
    
    Adding a retry for checking the state of an alert will allow time to prometheus-k8s to scrape
    the necessary metrics for a unit, without it we may run into a race condition where the assertion
    of the metric is run before prometheus is even able to scrape.
    This commit adds a retry logic to avoid this.
    
    Fixes #244
    DnPlas authored Feb 23, 2024
    Configuration menu
    Copy the full SHA
    d58d132 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. fix: Grafana dashboard shows data (#246)

    * Fix grafana dashboard by removing `uid` from the `datasource` fields.
    * Add tags `ckf` and `seldon` to dashboard.
    
    Part of canonical/bundle-kubeflow#856
    Refs canonical/bundle-kubeflow#834
    orfeas-k authored Apr 5, 2024
    Configuration menu
    Copy the full SHA
    0fc1e97 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Configuration menu
    Copy the full SHA
    f18f83a View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. ci: bump juju 3.1 -> 3.5 in main (#250)

    * ci: bump juju to 3.5
    
    Co-authored-by: NohaIhab <[email protected]>
    DnPlas and NohaIhab authored May 8, 2024
    Configuration menu
    Copy the full SHA
    2f7d8cc View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Configuration menu
    Copy the full SHA
    1f14dfd View commit details
    Browse the repository at this point in the history