fix(modal): update hasScrollingContent styles #14712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
approved these changes
Sep 26, 2023
|
@tay1orjones ohh its the inline margin-bottom style I had added to the select, its adding it to the element and not the wrapping div. Not sure we can fix that in the component without it being a breaking change. I updated the story to add a wrapper div. |
andreancardona
suggested changes
Sep 27, 2023
|
@andreancardona I already have a PR open to fix the chevron position (its unrelated to this PR) #14725 |
andreancardona
approved these changes
Sep 28, 2023
andreancardona
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13714
Update the styling for the scroll fade so that it appears inside the modal-content and there isn't an odd space below. This also fixes the issue where if you click in the space below the content it closes the modal.
Changelog
New
ModalandComposedModalChanged
modal-contentso the fade will appear inside the modalmodal-scroll-contentto accommodate the margin/padding swapTesting / Reviewing
Check styles for Modal and ComposedModal, focus should wrap entire content area above button.