Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIShell headerMenu - using esc to close the menu #3661

Closed
jingx-xue opened this issue Aug 6, 2019 · 1 comment
Closed

UIShell headerMenu - using esc to close the menu #3661

jingx-xue opened this issue Aug 6, 2019 · 1 comment
Labels
component: ui-shell severity: 1 https://ibm.biz/carbon-severity type: a11y ♿ type: bug 🐛

Comments

@jingx-xue
Copy link

Environment

Operating system: Win10

Browser: all browser

Automated testing tool and ruleset

Assistive technology used to verify

Detailed description

What version of the Carbon Design System are you using?
latest version
What did you expect to happen?
should using tab to close the menu like overflow menu compoent
What happened instead?
esc key is use to close the menu
What WCAG 2.1 checkpoint does the issue violate?

Steps to reproduce the issue

  1. tab to headerMenu component
  2. hit enter to open
  3. hit esc to ckose

Please create a reduced test case in CodeSandbox

Additional information

  • Screenshots or code
  • Notes
This was referenced Aug 8, 2019
Closed
Closed
@aledavila aledavila added this to the UI Shell - A11y Project Team milestone Sep 30, 2019
@dakahn dakahn added priority: high severity: 1 https://ibm.biz/carbon-severity labels Sep 30, 2019
@dakahn dakahn modified the milestones: UI Shell - A11y Project Team, Carbon WCAG Compliance Nov 21, 2019
@dakahn dakahn mentioned this issue Nov 22, 2019
Closed
@mattrosno mattrosno removed this from the ♿Carbon WCAG Compliance♿ milestone Dec 13, 2019
asudoh added a commit to asudoh/carbon-components that referenced this issue Dec 19, 2019
@asudoh
fix(HeaderMenu): support escape key
b533ec1 
Fixes carbon-design-system#3661.
@asudoh asudoh mentioned this issue Dec 19, 2019
Closed
@asudoh
Copy link
Contributor

asudoh commented Dec 20, 2019

Saw that ESC key is working with latest master.

@asudoh asudoh closed this as completed Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ui-shell severity: 1 https://ibm.biz/carbon-severity type: a11y ♿ type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(HeaderMenu): support escape key asudoh/carbon-components
5 participants
@asudoh @mattrosno @aledavila @dakahn @jingx-xue