fix(HeaderMenu): support escape key #4921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for the-carbon-components ready! Built with commit b533ec1 https://deploy-preview-4921--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react failed. Built with commit b533ec1 https://app.netlify.com/sites/carbon-components-react/deploys/5dfb9ffdcd2cc65edc09b0d1 |
|
Deploy preview for carbon-elements failed. Built with commit b533ec1 https://app.netlify.com/sites/carbon-elements/deploys/5dfb5723528aca000afe2c43 |
abbeyhrt
approved these changes
Dec 19, 2019
|
Good point on tests @abbeyhrt, which revealed that the tests as well as the feature code was already there and it's working with latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3661.
Changelog
New
<HeaderMenu>.Testing / Reviewing
Testing should make sure
<HeaderMenu>is not broken.