fix(web-components): fix icon package pathing for build #17590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisonjoseph
approved these changes
Sep 26, 2024
ariellalgilmore
approved these changes
Sep 26, 2024
ariellalgilmore
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
Merged
via the queue into
carbon-design-system:main
with commit Sep 26, 2024
6bd017d
23 checks passed
tay1orjones
pushed a commit
to tay1orjones/carbon
that referenced
this pull request
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
With the latest release updating the
@carbon/iconspackage version inweb-componentsto the latest version, the icons package pathing changes from thepackages/web-components/node_modulesfolder to directly pulling from thepackages/iconsfolder itself.This causes import issues for the web-components build as it needs to pull in the icon files. This PR adjusts the pathing to point to the icons package directly as the
@carbon/iconspackage no longer appears within the web-componentsnode_modulesfolder.This PR also changes the
publish-web-components-cdngithub actions workflow to build the entire project instead of just the web-components package as web-components has other carbon packages as dependencies.Changelog
Changed
packages/iconsinstead of web-components'node_modulespublish-web-components-cdnactions workflow to build entire projectTesting / Reviewing
Tested by using a locally generated tarball file
and using the file in one of the example web components stackblitz