Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web-components): fix icon package pathing for build #17590

Merged
merged 2 commits into from
Sep 26, 2024
Merged

fix(web-components): fix icon package pathing for build #17590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ceb0d93
fix(web-components): fix icon package pathing for build
annawen1 Sep 26, 2024
0c75b47
Merge branch 'main' into fix/adjust-icon-pathing
annawen1 Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/publish-web-components-cdn.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,8 @@ jobs:
node-version: '18.x'
cache: 'yarn'
- name: Install dependencies
run: yarn install
- name: Build Web Components package
run: |
cd packages/web-components
yarn install
yarn build
- name: Check release type
if: contains(github.ref_name, '-rc.')
Expand Down
4 changes: 2 additions & 2 deletions packages/web-components/tasks/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ async function build() {
]);

const iconInput = await globby([
'node_modules/@carbon/icons/lib/**/*.js',
'!**/index.js',
'../../packages/icons/lib/**/*.js',
'!../../packages/icons/lib/index.js',
]);

const entryPoint = {
Expand Down
4 changes: 2 additions & 2 deletions packages/web-components/tools/rollup-plugin-dist-icons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ import icon from './svg-result-carbon-icon.js';
* @returns {object} The rollup plugin to transform an `.svg` file to a `lit-html` template.
*/
export default function rollupPluginDistIcons({
include = /@carbon[\\/]icons[\\/]/i,
include = /packages[\\/]icons[\\/]lib[\\/]/i,
exclude,
} = {}) {
const filter = createFilter(include, exclude);
return {
name: 'lit-scss',
name: 'carbon-dist-icons',

/**
* Enqueues the module contents for loading.
Expand Down
Loading