Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert FeatureFlag Index.js file to Index.tsx #17600

Merged

Conversation

2nikhiltom
Copy link
Contributor

@2nikhiltom 2nikhiltom commented Sep 30, 2024

Closes #17589

Convers Index.js to Index.tsx

Changelog

Added FeatureFlagsProps interface

Testing / Reviewing

Verify no errors in console
ensure functionality is interact

Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit bff7ef2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66fbe26bb063140008dc3bee
😎 Deploy Preview https://deploy-preview-17600--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bff7ef2
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66fbe26baec2e20008dfe464
😎 Deploy Preview https://deploy-preview-17600--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.03%. Comparing base (29a4646) to head (eca9469).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17600   +/-   ##
=======================================
  Coverage   77.03%   77.03%           
=======================================
  Files         408      408           
  Lines       13993    13993           
  Branches     4301     4301           
=======================================
  Hits        10779    10779           
  Misses       3042     3042           
  Partials      172      172           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@2nikhiltom 2nikhiltom marked this pull request as ready for review September 30, 2024 11:09
@2nikhiltom 2nikhiltom requested a review from a team as a code owner September 30, 2024 11:09
Copy link
Contributor

@riddhybansal riddhybansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennylam kennylam added this pull request to the merge queue Oct 1, 2024
Merged via the queue into carbon-design-system:main with commit 7e6ec8e Oct 1, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert packages/react/src/components/FeatureFlags/index.js to .tsx
4 participants