Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: convert FeatureFlag Index.js file to Index.tsx #17600

Merged
merged 3 commits into from
Oct 1, 2024
Merged

fix: convert FeatureFlag Index.js file to Index.tsx #17600

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fbc6435
chore: remane file to .tsx to track change history
2nikhiltom Sep 30, 2024
eca9469
fix: convers file to .tsx
2nikhiltom Sep 30, 2024
bff7ef2
Merge branch 'main' into 17589_featureFlags_ts
2nikhiltom Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions ...eact/src/components/FeatureFlags/index.js → ...act/src/components/FeatureFlags/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,19 @@ import React, {
useEffect,
useRef,
useState,
ReactNode,
} from 'react';
import deprecate from '../../prop-types/deprecate';

interface FeatureFlagsProps {
children?: ReactNode;
flags?: Record<string, boolean>;
enableV12TileDefaultIcons?: boolean;
enableV12TileRadioIcons?: boolean;
enableV12Overflowmenu?: boolean;
enableTreeviewControllable?: boolean;
enableExperimentalFocusWrapWithoutSentinels?: boolean;
}
/**
* Our FeatureFlagContext is used alongside the FeatureFlags component to enable
* or disable feature flags in a given React tree
Expand All @@ -37,7 +48,7 @@ function FeatureFlags({
enableV12Overflowmenu = false,
enableTreeviewControllable = false,
enableExperimentalFocusWrapWithoutSentinels = false,
}) {
}: FeatureFlagsProps): JSX.Element {
const parentScope = useContext(FeatureFlagContext);
const [prevParentScope, setPrevParentScope] = useState(parentScope);

Expand Down Expand Up @@ -108,7 +119,11 @@ FeatureFlags.propTypes = {
* @param {Function} compare
* @param {Function} callback
*/
function useChangedValue(value, compare, callback) {
function useChangedValue<T>(
value: T,
compare: (a: T, b: T) => boolean,
callback: (value: T) => void
) {
const initialRender = useRef(false);
const savedCallback = useRef(callback);
const [prevValue, setPrevValue] = useState(value);
Expand Down Expand Up @@ -163,7 +178,10 @@ function useFeatureFlags() {
* @param {object} b
* @returns {boolean}
*/
function isEqual(a, b) {
function isEqual(
a: Record<string, boolean>,
b: Record<string, boolean>
): boolean {
if (a === b) {
return true;
}
Expand Down
Loading