fix(date-picker): support changing date format #4856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows change in `dateFormat` prop after initialization reflected correctly to the underlying Flatpickr. Fixes carbon-design-system#4848.
|
Deploy preview for the-carbon-components ready! Built with commit d2cfb15 https://deploy-preview-4856--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit d2cfb15 https://deploy-preview-4856--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit d2cfb15 |
abbeyhrt
approved these changes
Dec 11, 2019
|
Can anybody review and merge this PR? |
joshblack
approved these changes
Jan 6, 2020
figfofu
pushed a commit
to figfofu/carbon
that referenced
this pull request
Jan 7, 2020
Since flatpickr does not automatically update minDate and maxDate, we need to explicitly do it when the user makes any change in the props by using set(option, value) method from flatpickr Aligned to the change in carbon-design-system#4856
figfofu
pushed a commit
to figfofu/carbon
that referenced
this pull request
Jan 7, 2020
Since flatpickr does not automatically update minDate and maxDate, we need to explicitly do it when the user makes any change in the props by using set(option, value) method from flatpickr Aligned to the change in carbon-design-system#4856
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Jan 13, 2020
…4856) This change allows change in `dateFormat` prop after initialization reflected correctly to the underlying Flatpickr.
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Jan 14, 2020
…4856) This change allows change in `dateFormat` prop after initialization reflected correctly to the underlying Flatpickr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows change in
dateFormatprop after initialization reflected correctly to the underlying Flatpickr.Fixes #4848.
Changelog
New
dateFormatafter initialization to Flatpickr.Testing / Reviewing
Testing should make sure
<DatePicker>is not broken.